Add kind testing against ARM64 #457
Conversation
|
Build failed.
|
|
recheck |
|
Build failed.
|
|
Build failed.
|
|
Build failed.
|
|
For docker we can use the galaxy role - https://github.com/geerlingguy/ansible-role-docker docker_edition: ce |
|
For bazel we could use the role - https://galaxy.ansible.com/andrewrothstein/bazel |
|
recheck |
1 similar comment
|
recheck |
|
Build failed.
|
|
Build failed.
|
|
Build succeeded.
|
|
Build succeeded.
|
|
Build succeeded.
|
|
Build succeeded.
|
|
Zuul encountered a syntax error while parsing its configuration in the mapping values are not allowed in this context |
|
Zuul encountered a syntax error while parsing its configuration in the The project "kubernetes-sigs/kind" was not found. All projects The error appears in the following project stanza: project: in "theopenlab/openlab-zuul-jobs/zuul.d/projects.yaml@master", line 6, column 3 |
|
Build succeeded.
|
mrhillsman
changed the title
mrhillsman
requested review from
liusheng,
huangtianhua,
dims,
kiwik and
stmcginnis
|
Build succeeded.
|
|
Build succeeded.
|
|
Have a question here, I saw that in your commit there are a huge number of files added and that basically https://github.com/andrewrothstein/ansible-bazel and related requirements, I uderstand that we need it for the job, but could there be a way of not putting them all to the current roles? as we can see from https://github.com/theopenlab/openlab-zuul-jobs/tree/efa8423c2c7c711c3373a61ff6080afcb079deb9/roles you added quite alot files and the relationship between who depends on who can only be find when we actually open it and read the details, it seems really hard to understand what it actually does or maintain if we want to change something or, let's see, remove the job, we have to find out the relationship between each other. |
Dependencies for roles are found in the meta folder. This is a standard in ansible - https://docs.ansible.com/ansible/latest/user_guide/playbooks_reuse_roles.html#role-dependencies |
Signed-off-by: Melvin Hillsman <[email protected]>
|
Merge Failed. This change or one of its cross-repo dependencies was unable to be automatically merged with the current state of its repository. Please rebase the change and upload a new patchset. |
|
Build failed.
|
|
Build succeeded.
|
| @@ -141,6 +135,13 @@ | |||
| - packer-functional-devstack-mitaka: | |||
| branches: master | |||
|
|
|||
| - project: | |||
| name: kubernetes-sigs/kind | |||
|
|
||
| - project: | ||
| name: kubernetes-sigs/kind | ||
| periodic: |
There was a problem hiding this comment.
Hi @mrhillsman , we have done refactor for periodic pipeline, you add kind job at here in block periodic-0/12, but refer pipeline periodic, it's obvious error, please check document and choose a suitable pipeline.
| become: yes | ||
| roles: | ||
| - config-golang | ||
| - install-docker-ce |
There was a problem hiding this comment.
install-docker-ce should be updated to support ARM arch, like I say in previous comments.
- support ARM arch in https://github.com/theopenlab/openlab-zuul-jobs/blob/master/roles/install-docker-ce/tasks/main.yml#L24
- cgroupdriver is not supported in ARM arch, should be updated in https://github.com/theopenlab/openlab-zuul-jobs/blob/master/roles/install-docker-ce/tasks/main.yml#L40
So I believe docker can not be launched in current job define.
| go get sigs.k8s.io/kind | ||
| go get k8s.io/kubeadm | ||
| go get k8s.io/kubernetes | ||
| go get k8s.io/test-infra |
There was a problem hiding this comment.
seems should be go get -u k8s.io/test-infra/kubetest according to https://github.com/kubernetes/test-infra/tree/master/kubetest I failed to install it with your command(it didn't got installed since it is a too wide package) and succed with go get -u k8s.io/test-infra/kubetest
| --kind-binary-version=build \ | ||
| --kind-base-image="kindest/base:latest" \ | ||
| --kind-config-path=./../../k8s.io/kubeadm/tests/e2e/kind/single-cp/single-cp.yaml \ | ||
| --build=bazel \ |
There was a problem hiding this comment.
I think the --build=bazel is not neccessary as seems from https://github.com/kubernetes/test-infra/blob/master/kubetest/kind/kind.go#L241 if we don't pass anything, we will use existing node-image(which was built in line 27) passing other value will trigger a re-build of the node-image which makes the previous build useless.
| cmd: | | ||
| cd $GOPATH/src/sigs.k8s.io/kind && go install . | ||
| kind build base-image --image kindest/base:latest --source $GOPATH/src/sigs.k8s.io/kind/images/base --loglevel debug | ||
| kind build node-image --type bazel --image kindest/node:latest --base-image kindest/base:latest --kube-root=$GOPATH/src/k8s.io/kubernetes/ --loglevel debug |
There was a problem hiding this comment.
I think we can just remove this one if you are using --build=bazel in the below command, it takes around 20 mins for each build in our vexxhost vm, so quite time consuming to build twice.
Request: theopenlab/openlab#211