Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: Drop deprecated @mui/base package #638

Merged
merged 1 commit into from
Jan 30, 2025
Merged

chore: Drop deprecated @mui/base package #638

merged 1 commit into from
Jan 30, 2025
+0 −47

Conversation

DafyddLlyr
Copy link
Contributor

@DafyddLlyr DafyddLlyr commented Jan 29, 2025 •
edited
Loading

Hitting some build issue in planx-new which references this import via planx-core. The package is deprecated and unused, here's what I've checked -

  • Library builds
  • Library passes tests
  • pnpm examples works
  • No references in code to @mui/base

@DafyddLlyr DafyddLlyr marked this pull request as draft January 29, 2025 10:49
@DafyddLlyr DafyddLlyr changed the title chore: Drop deprecated mui base chore: Drop deprecated @mui/base package Jan 29, 2025
@DafyddLlyr DafyddLlyr requested a review from a team January 29, 2025 11:38
jamdelion
jamdelion approved these changes Jan 29, 2025
View reviewed changes
Copy link
Contributor

@jamdelion jamdelion left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Using this PR's commit hash fixes my planx-new issues 🙌 I've also ran pnpm run examples on this branch and checked the repo for references to mui/base and couldn't find any beyond pnpm-lock.yaml.

Thanks for picking this up! 🦸

@DafyddLlyr DafyddLlyr marked this pull request as ready for review January 30, 2025 16:38
@DafyddLlyr DafyddLlyr merged commit 9017391 into main Jan 30, 2025
3 checks passed
@DafyddLlyr DafyddLlyr deleted the dp/drop-deprecated-mui-base branch January 30, 2025 16:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jamdelion jamdelion jamdelion approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@DafyddLlyr @jamdelion