Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rat #303

Merged
merged 1 commit into from
Jul 19, 2023
Merged

Rat #303

merged 1 commit into from
Jul 19, 2023

Conversation

atampy25
Copy link
Contributor

SMF contracts

  • it didn't vanilla contracts before
  • now it does what it says it does in the docs

@atampy25 atampy25 added the urgent This needs to be prioritized. label Jul 19, 2023
@LennardF1989
Copy link
Member

LennardF1989 commented Jul 19, 2023 •
edited
Loading

Holy macaroni, that's a lot of nested if-statements in that piece of code... The amount of requested reviewers also seems a bit excessive, doubt this is really that urgent. I can't test this ATM, so I'll leave it to someone else. The === "undefined" seems weird, though, there is probably a story behind that.

@AnthonyFuller
Copy link
Contributor

The next time you add more than the required people to review a PR, you're getting blocked from making them.

@AnthonyFuller AnthonyFuller merged commit 1d1f811 into thepeacockproject:v6 Jul 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AnthonyFuller AnthonyFuller AnthonyFuller approved these changes

Assignees
No one assigned
Labels
urgent This needs to be prioritized.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@atampy25 @LennardF1989 @AnthonyFuller