Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add descriptions to Peacock escalations #320

Conversation

jorys-paulin
Copy link
Contributor

Hello everyone!

This pull request adds descriptions to every Peacock escalation, translated in all languages.

This actually fixes a bug with the "missing content" popup, where Peacock escalations don't show up properly.

For official escalations, players who don't own the required entitlement will get a popup that shows the content they're trying to access (including its description), the required content, and links to the relevant store:

HITMAN3_2023-09-11_20-41-32

However, for Peacock escalations this popup is broken, because their contract files are missing a Description field:

HITMAN3_2023-09-11_20-41-15

Adding descriptions fixes this issue, and now the popup looks as expected (and in user's language too!):

HITMAN3_2023-09-11_20-42-51

I've made sure the translations are correct and consistent with the game for French and German. Other languages were manually translated using the game's other translations and Google Translate, so I can't guarantee they are 100% accurate (Chinese for example), so a little checkup by the translators wouldn't hurt.

Copy link
Member

@moonysolari moonysolari left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please only add translations for languages you are proficient in, and do not use AI translation tools to do the translations.

@jorys-paulin
Copy link
Contributor Author

Please only add translations for languages you are proficient in, and do not use AI translation tools to do the translations.

Should I just leave then untranslated in English then? That's going to look weird. Also, I don't think Google Translate is an "AI translation tool".

@moonysolari
Copy link
Member

Yeah, just leave them in english.

@jorys-paulin
Copy link
Contributor Author

I've un-translated them, since I've basically copy-pasted and checked them they're probably fine, but feel free to reach out to the translators later!

Copy link
Contributor

@AnthonyFuller AnthonyFuller left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR is unnecessarily large. The descriptions are the same per escalation, so they should be UI_PEACOCK_ESCALATION_<LOCATION>_DESC e.g. UI_PEACOCK_ESCALATION_PARIS_DESC.

@jorys-paulin
Copy link
Contributor Author

I've updated the descriptions to generic ones, they will now be "Peacock escalation in (Destination)". I've translated those in French and German, other languages fall back on English.

HITMAN3_2023-09-18_13-52-34
HITMAN3_2023-09-18_13-52-57

@suanjiansalt
Copy link
Contributor

As we've gone this far... how about adding descriptions to all destinations as we may have further escalations? @jorys-paulin

@AnthonyFuller
Copy link
Contributor

I don't want to needlessly bloat the l10n file with strings that aren't used now, and may not even be used in the future. They'll be added as and when required.

@AnthonyFuller AnthonyFuller merged commit f8c8985 into thepeacockproject:v7 Sep 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants