Enable strict types mode #362
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Reece Dunham <[email protected]>
Signed-off-by: Reece Dunham <[email protected]>
…t/Peacock into rdil/type-fixes
Signed-off-by: Reece Dunham <[email protected]>
Signed-off-by: Reece Dunham <[email protected]>
Signed-off-by: Reece Dunham <[email protected]>
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
RDIL
commented
Jan 15, 2024
Comment on lines
-177
to
+165
| challenge.InclusionData.ContractTypes.filter( | ||
| challenge.InclusionData?.ContractTypes?.filter( | ||
| (type) => type !== "tutorial", | ||
| ), | ||
| ) || [], |
Comment on lines
+232
to
242
| const mainGroup = gameGroups.get(location)?.get(groupId) | ||
|
|
||
| if (groupId === "feats" && gameVersion !== "h3") { | ||
| if (!mainGroup) { | ||
| // emergency bailout - shouldn't happen in practice | ||
| return undefined | ||
| } | ||
|
|
||
| return mergeSavedChallengeGroups( | ||
| gameGroups.get(location)?.get(groupId), | ||
| mainGroup, | ||
| gameGroups.get("GLOBAL_ESCALATION_CHALLENGES")?.get(groupId), |
Signed-off-by: Reece Dunham <[email protected]>
Signed-off-by: Reece Dunham <[email protected]>
Signed-off-by: Reece Dunham <[email protected]>
Signed-off-by: Reece Dunham <[email protected]>
Signed-off-by: Reece Dunham <[email protected]>
Signed-off-by: Reece Dunham <[email protected]>
Signed-off-by: Reece Dunham <[email protected]>
Signed-off-by: Reece Dunham <[email protected]>
Signed-off-by: Reece Dunham <[email protected]>
Signed-off-by: Reece Dunham <[email protected]>
Signed-off-by: Reece Dunham <[email protected]>
Signed-off-by: Reece Dunham <[email protected]>
Signed-off-by: Reece Dunham <[email protected]>
Signed-off-by: Reece Dunham <[email protected]>
Signed-off-by: Reece Dunham <[email protected]>
Signed-off-by: Reece Dunham <[email protected]>
Signed-off-by: Reece Dunham <[email protected]>
RDIL
added a commit
that referenced
this pull request
Feb 2, 2024
Signed-off-by: Reece Dunham <[email protected]>
This was referenced Feb 2, 2024
|
I have a feeling that this PR has brought about more bugs than we realize... |
|
It probably has, but without people able to test it, we won't know. |
A small price to pay for the greater good, IMO. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Slowly but surely enabling strict null checking on the codebase for enhanced security.
Opening this PR just to note for myself where potentially breaking changes are.