Fixed performance issue with JSON files #40
Conversation
LennardF1989
force-pushed
the
json-performance
branch
from
0c83f3c to
6fc9e31
Compare
packaging/build.mjs
Outdated
| const jsonAsCompressedTextPlugin = { | ||
| name: "jsonAsCompressedTextPlugin", | ||
|
|
||
| setup(build) { | ||
| let fs = require("fs") | ||
|
|
||
| build.onLoad({ filter: /\.json$/ }, async (args) => { | ||
| const text = await fs.promises.readFile(args.path) | ||
|
|
||
| return { | ||
| contents: JSON.stringify(JSON.parse(text)), | ||
| loader: "text", | ||
| } | ||
| }) | ||
| }, | ||
| } |
There was a problem hiding this comment.
I think this can just use the loader option instead of making this a plugin.
There was a problem hiding this comment.
Nope, that was my first attempt and it will only treat it as text*, and not actually remove indentation like I do now. The JSON loader will turn it into an object, so this is the only way to do it and also "compress" the actual resulting string :)
* loaders is also a fixed list of available loaders.
There was a problem hiding this comment.
let fs = require("fs") I want to change this to const though. Using an import doesn't work do to the way esbuild works with plugins.
LennardF1989
force-pushed
the
json-performance
branch
2 times, most recently
from
3cad4f4 to
55787b8
Compare
|
Tested in-game:
Startup time significantly reduced. Build size significantly reduced (6.5MB after optimizing). EDIT: Also, my test-branch is reliant on this fix, which is also ready for further extension by taking it into the core. |
LennardF1989
force-pushed
the
json-performance
branch
from
55787b8 to
6d9049e
Compare
Makes changes to the build process to handle imported JSON files differently. This significantly increases startup time (favorable for unit testing), as well as pretty significantly decreasing the final build size when building (going from 27 mb to just 7 mb).
Changes for speed: The JSON imports will be loaded as strings instead of JavaScript objects.
Changes for build size: The JSON imports will be reserialized without indentation.
Draft because I want to verify if things still work as intended (they should, though).