Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

$schema->nullable can be null as of cebe/php-openapi 1.6 #154

Closed
canvural opened this issue Feb 10, 2022 · 2 comments · Fixed by #155
Closed

$schema->nullable can be null as of cebe/php-openapi 1.6 #154

canvural opened this issue Feb 10, 2022 · 2 comments · Fixed by #155

Comments

@canvural
Copy link
Contributor

Hello,

I just updated to cebe/php-openapi 1.6.0 and got an error in my test suite.

As of 1.6.0, $schema->nullable can be null : https://github.com/cebe/php-openapi/blob/master/src/spec/Schema.php#L130

This causes error here: https://github.com/thephpleague/openapi-psr7-validator/blob/master/src/Schema/SchemaValidator.php#L60 Argument #2 ($nullable) must be of type bool, null given

Currently I don't have time send a PR with a fix. So just reporting it.

@cebe
Copy link

cebe commented Feb 10, 2022

Linking related discussions for reference:

@scaytrase
Copy link
Member

Implemented quick fix

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants