Fix schema.nullable #155
Merged
Fix schema.nullable #155
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cebe
reviewed
Feb 10, 2022
| @@ -23,7 +23,7 @@ | |||
| "require": { | |||
| "php": ">=7.2", | |||
| "ext-json": "*", | |||
| "cebe/php-openapi": "^1.3", | |||
| "cebe/php-openapi": "^1.6", | |||
There was a problem hiding this comment.
your fix should also work with older versions.
There was a problem hiding this comment.
Test from #146 fails because of lack of logic invented here cebe/php-openapi#132
So in order to make this test pass - we should have ^1.6.0
tunezilla
added a commit
to tunezilla/openapi-test-validation
that referenced
this pull request
Aug 2, 2022
leNEKO
reviewed
May 2, 2024
| @@ -57,7 +57,7 @@ public function validate($data, CebeSchema $schema, ?BreadCrumb $breadCrumb = nu | |||
|
|
|||
| try { | |||
| // These keywords are not part of the JSON Schema at all (new to OAS) | |||
| (new Nullable($schema))->validate($data, $schema->nullable); | |||
| (new Nullable($schema))->validate($data, $schema->nullable ?? true); | |||
There was a problem hiding this comment.
(I didn't understand why we want nullable true by default instead of false ?)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #154
Fixes #146