Period::contains edge checking is confusing #28
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Oki I found the bug and I've just fixed it 👍 It will be on the master branch and published tomorrow if I have the time. I'll let you know ASAP! |
|
thanks! |
|
@bendavies the bug fix landed on master... you can already try it there. If everything is good I'll put it on production tomorrow |
|
awesome! thanks |
|
That's great. please tag away! |
|
version 3.0.1 is released |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There is some weirdness with edge checking that I've encountered.
Consider the following:
What would you think that should return?
I would say
true, but the current implementation will returnfalse. This seems very counterintuitive, given the example.Thoughts?
I realise this PR fails the tests. It's just for a discussion starting point.