Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: put types in .d.ts #7

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Conversation

yoursunny
Copy link
Contributor

No description provided.

Copy link

Removed dependencies detected. Learn more about Socket for GitHub ↗︎

🚮 Removed packages: npm/@types/[email protected]

View full report↗︎

@yoursunny
Copy link
Contributor Author

In my fork @yoursunny/asn1 package, the .d.ts file refers to the @types/root__asn1 package (also written by me) with a re-export:

export * from "@root/asn1";

Effectively, it means "@yoursunny/asn1 has the same types as @root/asn1".

However, copying this re-export to this package would not work, because it effectively means "@root/asn1 has the same types as @root/asn1".
You'll have to put the actual types in the .d.ts file.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant