This repository has been archived by the owner on Nov 17, 2022. It is now read-only.
Add permissions v2 support #4
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is not yet tested and still a work in progress
|
Maybe should just add |
|
Eh, then you lose type hints because you would annotate |
|
Just in addition to the already known args. |
Should work, hopefully...
…ius/tanchi into feature/permissions-v2
|
I think I messed up the commit history lol |
|
I have no idea why the tests are failing |
thesadru
added a commit
that referenced
this pull request
Aug 29, 2022
Co-authored-by: GoogleGenius <[email protected]>
thesadru
added a commit
that referenced
this pull request
Aug 29, 2022
Co-authored-by: GoogleGenius <[email protected]>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WIP:
hikari-py/hikari#1148
FasterSpeeding/Tanjun#296