Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Show values in USD in Ledger Live dApp #121

Closed
4 tasks done
Tracked by #157
nkuba opened this issue Jan 2, 2024 · 0 comments
Closed
4 tasks done
Tracked by #157

Show values in USD in Ledger Live dApp #121

nkuba opened this issue Jan 2, 2024 · 0 comments
Labels
🎨 dApp dApp

Comments

@nkuba
Copy link
Member

nkuba commented Jan 2, 2024 •
edited by ioay
Loading

Some of the values should be displayed in both BTC and USD.

Depends on: #236

Tasks
Preview Give feedback
@nkuba nkuba mentioned this issue Jan 2, 2024
Closed
@nkuba nkuba added the 🎨 dApp dApp label Jan 2, 2024
@nkuba nkuba mentioned this issue Jan 15, 2024
Closed
@nkuba nkuba mentioned this issue Feb 12, 2024
Closed
@ioay ioay mentioned this issue Feb 20, 2024
Merged
ioay added a commit that referenced this issue Mar 4, 2024
@ioay
React redux implementation, fetching current price of BTC (#245)
846494b 
> Closes #236 #121 

------------------

### Initialize Redux support to store state
### Show values in USD in Ledger Live dApp

------------------

### _What was done:_

- Added packages: `react-redux, ver. ^9.1.0` | `@reduxjs/toolkit", ver:
^2.2.0`
- Disabled `eslint` no-param-reassign rule for slice files. `Redux
Toolkit` uses `Immer` under the hood to write simpler immutable update
logic using "mutating" syntax.
- Updated `asyncWrapper` to `logPromiseFailure` method to catch
promises.
- Added `useCurrencyConversion` hook to calculate values from BTC to
USD. It should be updated to handle other currencies if appears in the
redux store.
- Added `useFetchBTCPriceUSD` hook to get bitcoin price from `Coingecko
API`.
- `redux dev tools `are enabled for all environments, excluding `PROD`
env.

------------------

### _Preview:_ 

<img width="459" alt="Screenshot 2024-03-01 at 18 24 52"
src="https://github.com/thesis/acre/assets/28560653/3715268c-4b82-4c56-88de-a8cf2a9c4ee2">
@nkuba nkuba closed this as completed Mar 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
🎨 dApp dApp
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@nkuba @ioay