Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Subgraph: Fix withdrawal finalization support #562

Closed
Tracked by #457
nkuba opened this issue Jul 5, 2024 · 0 comments · Fixed by #601
Closed
Tracked by #457

Subgraph: Fix withdrawal finalization support #562

nkuba opened this issue Jul 5, 2024 · 0 comments · Fixed by #601
Assignees

Comments

@nkuba
Copy link
Member

nkuba commented Jul 5, 2024

As mentioned in #513:

Currently, we do not support the withdrawals finalization - I need to investigate why the wrong redemption key is built based on the parameters from the submitRedemptionProof call.

We must figure out what's wrong and fully support it in the Acre subgraph.
Once solved, we need to remove the Threshold subgraph reference in SDK.

This was referenced Jul 5, 2024
kkosiorowska added a commit that referenced this issue Jul 9, 2024
This PR adds support for indexing the withdrawals in Acre. Here we
subscribe to the `RedemptionRequested` event from the tBTC Bridge
contract. Because we are listening to events from tBTC bridge not from
`BitcoinRedeemer` we must make sure the withdrawal comes from the Acre
network (the Acre subgraph should index only Acre withdrawals). Also,
t's possible to create 2 redemptions with the same redemption key in
tBTC v2 network (once the previous ones are finalized- meaning only one
pending redemption with the same key can exist). In that case we must
add a suffix to the `Withdraw` id - we count redemptions with the same
redemption key in `RedemptionKeyCounter` entity.

Currently, we do not support the withdrawals finalization - I need to
investigate why the wrong redemption key is built based on the
parameters from the `submitRedemptionProof` call.
This will be handled in #562

Closes: #276
Closes: #268
@nkuba nkuba added 🔌 SDK TypeScript SDK Library 📈 Subgraph and removed 🔌 SDK TypeScript SDK Library labels Jul 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants