Update @thesis-co/eslint-config to the latest 0.8.0-pre version

.github/workflows/core.yaml

@@ -13,7 +13,7 @@ defaults:
     working-directory: ./core
 
 jobs:
-  core-format:
+  core-build:
     runs-on: ubuntu-latest
     steps:
       - uses: actions/checkout@v4
@@ -30,10 +30,20 @@ jobs:
       - name: Install Dependencies
         run: pnpm install --prefer-offline --frozen-lockfile
 
-      - name: Format
-        run: pnpm run format
+      - name: Build
+        run: pnpm run build
 
-  core-build:
+      - name: Upload Build Artifacts
+        uses: actions/upload-artifact@v3
+        with:
+          name: core-build
+          path: |
+            core/build/
+            core/typechain/
+          if-no-files-found: error
+
+  core-format:
+    needs: [core-build]
     runs-on: ubuntu-latest
     steps:
       - uses: actions/checkout@v4
@@ -50,17 +60,14 @@ jobs:
       - name: Install Dependencies
         run: pnpm install --prefer-offline --frozen-lockfile
 
-      - name: Build
-        run: pnpm run build
-
-      - name: Upload Build Artifacts
-        uses: actions/upload-artifact@v3
+      - name: Download Build Artifacts
+        uses: actions/download-artifact@v3
         with:
           name: core-build
-          path: |
-            core/build/
-            core/typechain/
-          if-no-files-found: error
+          path: core/
+
+      - name: Format
+        run: pnpm run format
 
   core-slither:
     needs: [core-build]

core/deploy/00_resolve_tbtc.ts

@@ -4,6 +4,7 @@ import { isNonZeroAddress } from "../helpers/address"
 
 const func: DeployFunction = async (hre: HardhatRuntimeEnvironment) => {
   const { getNamedAccounts, deployments } = hre
+  // eslint-disable-next-line @typescript-eslint/unbound-method
   const { log } = deployments
   const { deployer } = await getNamedAccounts()
 

core/deploy/21_transfer_ownership_acre.ts

@@ -4,6 +4,7 @@ import type { DeployFunction } from "hardhat-deploy/types"
 const func: DeployFunction = async (hre: HardhatRuntimeEnvironment) => {
   const { getNamedAccounts, deployments } = hre
   const { deployer, governance } = await getNamedAccounts()
+  // eslint-disable-next-line @typescript-eslint/unbound-method
   const { log } = deployments
 
   log(`transferring ownership of Acre contract to ${governance}`)
@@ -20,4 +21,5 @@ export default func
 
 func.tags = ["TransferOwnershipAcre"]
 // TODO: Enable once Acre extends Ownable
+// eslint-disable-next-line @typescript-eslint/require-await
 func.skip = async () => true

core/deploy/22_transfer_ownership_acre_router.ts

@@ -4,6 +4,7 @@ import type { DeployFunction } from "hardhat-deploy/types"
 const func: DeployFunction = async (hre: HardhatRuntimeEnvironment) => {
   const { getNamedAccounts, deployments } = hre
   const { deployer, governance } = await getNamedAccounts()
+  // eslint-disable-next-line @typescript-eslint/unbound-method
   const { log } = deployments
 
   log(`transferring ownership of Dispatcher contract to ${governance}`)

core/package.json

@@ -35,7 +35,7 @@
     "@nomicfoundation/hardhat-verify": "^2.0.1",
     "@nomiclabs/hardhat-etherscan": "^3.1.7",
     "@openzeppelin/hardhat-upgrades": "^2.4.1",
-    "@thesis-co/eslint-config": "^0.6.1",
+    "@thesis-co/eslint-config": "github:thesis/eslint-config#7b9bc8c",
     "@typechain/ethers-v6": "^0.5.1",
     "@typechain/hardhat": "^9.1.0",
     "@types/chai": "^4.3.11",

core/test/Acre.test.ts

@@ -3,6 +3,7 @@ import {
   loadFixture,
 } from "@nomicfoundation/hardhat-toolbox/network-helpers"
 import { expect } from "chai"
+import { ethers } from "hardhat"
 import { ContractTransactionResponse, ZeroAddress } from "ethers"
 
 import type { HardhatEthersSigner } from "@nomicfoundation/hardhat-ethers/signers"
@@ -20,8 +21,8 @@ async function fixture() {
   const [staker1, staker2] = await getUnnamedSigner()
 
   const amountToMint = to1e18(100000)
-  tbtc.mint(staker1, amountToMint)
-  tbtc.mint(staker2, amountToMint)
+  await tbtc.mint(staker1, amountToMint)
+  await tbtc.mint(staker2, amountToMint)
 
   return { acre, tbtc, staker1, staker2 }
 }
@@ -37,7 +38,7 @@ describe("Acre", () => {
   })
 
   describe("stake", () => {
-    const referral = ethers.encodeBytes32String("referral")
+    const referral: string = ethers.encodeBytes32String("referral")
     let snapshot: SnapshotRestorer
 
     context("when staking as first staker", () => {
@@ -74,8 +75,8 @@ describe("Acre", () => {
             .stake(amountToStake, receiver.address, referral)
         })
 
-        it("should emit Deposit event", () => {
-          expect(tx).to.emit(acre, "Deposit").withArgs(
+        it("should emit Deposit event", async () => {
+          await expect(tx).to.emit(acre, "Deposit").withArgs(
             // Caller.
             tbtcHolder.address,
             // Receiver.
@@ -87,8 +88,8 @@ describe("Acre", () => {
           )
         })
 
-        it("should emit StakeReferral event", () => {
-          expect(tx)
+        it("should emit StakeReferral event", async () => {
+          await expect(tx)
             .to.emit(acre, "StakeReferral")
             .withArgs(referral, amountToStake)
         })
@@ -367,7 +368,7 @@ describe("Acre", () => {
           sharesBefore = await acre.balanceOf(staker1.address)
           availableToRedeemBefore = await acre.previewRedeem(sharesBefore)
 
-          tbtc.mint(staker1.address, newAmountToStake)
+          await tbtc.mint(staker1.address, newAmountToStake)
 
           await tbtc
             .connect(staker1)

core/test/helpers/contract.ts

@@ -1,5 +1,4 @@
-import { ethers } from "ethers"
-import { deployments } from "hardhat"
+import { deployments, ethers } from "hardhat"
 
 import type { BaseContract } from "ethers"
 import { getUnnamedSigner } from "./signer"

sdk/package.json

@@ -14,7 +14,7 @@
     "test": "mocha --exit --recursive 'test/**/*.test.ts'"
   },
   "devDependencies": {
-    "@thesis-co/eslint-config": "^0.6.1",
+    "@thesis-co/eslint-config": "github:thesis/eslint-config#7b9bc8c",
     "@types/chai": "^4.3.11",
     "@types/mocha": "^10.0.6",
     "@types/node": "^20.9.4",

website/package.json

@@ -28,7 +28,7 @@
     "react-helmet": "^6.1.0"
   },
   "devDependencies": {
-    "@thesis-co/eslint-config": "^0.6.1",
+    "@thesis-co/eslint-config": "github:thesis/eslint-config#7b9bc8c",
     "@types/node": "^20.9.4",
     "@types/react": "^18.2.38",
     "@types/react-dom": "^18.2.17",