-
Notifications
You must be signed in to change notification settings - Fork 445
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rethink writing of double quotes around value to in flatten_and_write #15
Comments
Yeah, they do make sense. The problem was that the tool loading the environment variables (not with python-dotenv) was tripping upon them. But I guess I better fix that tool :) |
I use this library to mantain my dotenv files across a number of projects, but I have a problem with Docker and it's that for Docker an envfile gets parsed as if you split the lines by the equal sign, everything before the equal is the variable name, the rest is the value, the problem is that you end up with quotes in your values which breaks some applications. I guess changing the behavior by default could be a breaking change, maybe a good compromise is to support a flag to set the behavior:
I would add the "auto" behavior to support sourcing dotenv files from bash, i use this a lot while debugging, the problem with unquoted strings containing whitespace is that bash thinks you are trying to run a command. |
Support for configurable quoting mode, references #15
Just released 0.4.0 with this functionality. 🎉 @hugochinchilla are you able to install the new version and confirm it works for you. Thanks. |
Works amazingly, thank you for merging so fast. |
Released 0.6.0 containing this change is on PYPI. Yay! |
@theskumar I think you wanted to post your last comment on PR #30 ;) Thanks for merging :) |
See #13
The text was updated successfully, but these errors were encountered: