ucm: Code simplification and fixes #11
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Default constructors for abstract classes are not referenced anywhere. Signed-off-by: Cezary Rojewski <[email protected]>
First, handle case where value provided is null to avoid ArgumentNullException. Second, be more thorough when splitting string-representation of constants into separate entries. That is, trim and remove empty entries. Last, while '_' is part of PCM_RATE constants names, do not allow for ambiguity and treat rate-strings such as "_192000" as invalid. Signed-off-by: Cezary Rojewski <[email protected]>
No need for else-if-statements if the preceding if-statement ends with return. Signed-off-by: Cezary Rojewski <[email protected]>
While abstract classes cannot be instantiated, for consistency streamline TokenType value returned for the base Section-type. Signed-off-by: Cezary Rojewski <[email protected]>
TypeDescriptor::GetConverter() either returns non-null value or throws an exception so remove the existing null-check. Signed-off-by: Cezary Rojewski <[email protected]>
Improves readability. Signed-off-by: Cezary Rojewski <[email protected]>
Throw null-exception when invalid stream is specified. Signed-off-by: Cezary Rojewski <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A range of fixes aiming to improve code quality.
It starts with removal of unused ctors for the abstract classes - unused and not intended to be used by inheriting classes. While most of remaining patches are pretty self explanatory, the largest change rewrites FormatsString and RatesString property. Goal is to remove any ambiguity by improving string-parsing mechanism and dropping empty entries before doing so.