Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BUG] Audio device not recognized on HP Omen 17 #1658

Closed
singingtelegram opened this issue Dec 21, 2019 · 8 comments
Closed

[BUG] Audio device not recognized on HP Omen 17 #1658

singingtelegram opened this issue Dec 21, 2019 · 8 comments
Assignees
@kv2019i
Labels
bug Something isn't working HDA Applies to HD-Audio bus for codec connection P2 Critical bugs or normal features

Comments

@singingtelegram
Copy link

Describe the bug
No audio device (except dummy device) available.

To Reproduce
Upgrade to 5.4 kernel. / Attempt to make DMIC available under Linux by blacklisting snd_hda_intel and switching to SOF (kernel bug #201251).

Reproduction Rate
10/10

Expected behavior
SOF firmware is loaded and the audio device is detected.

Impact
Unable to output audio.

Environment
Platform: HP OMEN by HP Laptop 17-cb0xxx
Graphics: IGP Disabled / Nvidia Turing
Audio device: 00:1f.3 Multimedia audio controller: Intel Corporation Cannon Lake PCH cAVS (rev 10) / Realtek ALC285 / Microphone Array - Intel Smart Sound Technology (under Windows - not detected with snd_hda_intel)
Kernel: 5.4.x and 5.5rc2
Topology: probably irrelevant as firmware wasn't even loaded, but all topology files were copied to /usr/lib/firmware/intel/sof-tplg.

Screenshots or console output

  • lspci -kv:
00:1f.3 Multimedia audio controller: Intel Corporation Cannon Lake PCH cAVS (rev 10)
	Subsystem: Hewlett-Packard Company Cannon Lake PCH cAVS
	Flags: bus master, fast devsel, latency 32, IRQ 16
	Memory at da210000 (64-bit, non-prefetchable) [size=16K]
	Memory at da100000 (64-bit, non-prefetchable) [size=1M]
	Capabilities: <access denied>
	Kernel driver in use: sof-audio-pci
	Kernel modules: snd_hda_intel, snd_sof_pci
  • dmesg entries:
[    2.606198] sof-audio-pci 0000:00:1f.3: DSP detected with PCI class/subclass/prog-if info 0x040100
[    2.647708] sof-audio-pci 0000:00:1f.3: Digital mics found on Skylake+ platform, using SOF driver
[    2.647721] sof-audio-pci 0000:00:1f.3: enabling device (0000 -> 0002)
[    2.648231] sof-audio-pci 0000:00:1f.3: warning: No matching ASoC machine driver found
[    2.648235] sof-audio-pci 0000:00:1f.3: DSP detected with PCI class/subclass/prog-if 0x040100
[    2.648390] sof-audio-pci 0000:00:1f.3: use msi interrupt mode
[    2.649128] sof-audio-pci 0000:00:1f.3: error: init i915 and HDMI codec failed
[    2.649239] sof-audio-pci 0000:00:1f.3: error: failed to probe DSP -19
[    2.649267] sof-audio-pci 0000:00:1f.3: error: sof_probe_work failed err: -19

Related reports
https://bugs.archlinux.org/task/64720 - same device
@lgirdwood
Copy link
Member

@mengdonglin this looks like we have some kconfig? misconfiguration of graphics since i915 init is failing. Can someone in PRC check this. Thanks

@plbossart
Copy link
Member

@lgirdwood @kv2019i this looks like a larger problem: if the intel graphics is not enabled, then all the logic in the machine driver to use iDISP links will fail, and so will the UCM parts...That really means we need to enable the case when iDISP is not present

We don't have such a device in our development set so no wonder it wasn't seen earlier...

@plbossart plbossart transferred this issue from thesofproject/sof Jan 2, 2020
@lgirdwood
Copy link
Member

lgirdwood commented Jan 6, 2020 •
edited
Loading

@wenqingfu @mengdonglin fyi, there is need for testing HW without Intel graphics.

@plbossart @kv2019i I'm assuming here we don't depend on the i915 HW for the ASoC machine driver probe() initiation but for machine driver probe() completion or DAI binding?

@plbossart
Copy link
Member

@plbossart @kv2019i I'm assuming here we don't depend on the i915 HW for the ASoC machine driver probe() initiation but for machine driver probe() completion or DAI binding?

IIRC if the i915 interaction fails we stop the probe...

@kv2019i kv2019i added the bug Something isn't working label Jan 8, 2020
@kv2019i kv2019i self-assigned this Jan 8, 2020
@kv2019i
Copy link
Collaborator

kv2019i commented Jan 8, 2020

@plbossart @lgirdwood This is a clear bug. We should support the IGP disabled case with the default machine driver, but with current code we don't as SOF DSP driver probe will fail if I915 init fail.
I'll make a fix to this.

@kv2019i kv2019i added P2 Critical bugs or normal features HDA Applies to HD-Audio bus for codec connection labels Jan 8, 2020
@kv2019i kv2019i mentioned this issue Jan 17, 2020
Closed
kv2019i added a commit to kv2019i/linux that referenced this issue Feb 17, 2020
@kv2019i
ASoC: intel/skl/hda - add no-HDMI cases to generic HDA driver
1baa120 
Extend the generic HDA driver to support systems where iDisp/HDMI
audio codecs are disabled for some reason. Switch codecs to
SoC dummy in the affected DAI links. This allows to reuse
existing topologies for this case.

BugLink: thesofproject#1658
BugLink: https://bugzilla.opensuse.org/show_bug.cgi?id=1163677
BugLink: https://bugzilla.kernel.org/show_bug.cgi?id=206085
Signed-off-by: Kai Vehmanen <[email protected]>
kv2019i added a commit to kv2019i/linux that referenced this issue Feb 17, 2020
@kv2019i
ASoC: SOF: Intel: hda: allow operation without i915 gfx
378af3e 
Add support to configure the HDA controller with an external HDA
codec even if iDisp codec in i915 is not available.

This can happen for multiple reasons:
 - internal graphics is disabled on the system
 - i915 driver is not enabled in kernel or it fails to init
 - i915 codec reports error in HDA codec probe
 - HDA codec driver probe fails

Address all these scenarios, but keep using the existing topology.
In case failures occur, HDMI PCM nodes are created, but they will
report error if application tries to use them. No ALSA mixer controls
are created. If the external HDA codec init fails as well, SOF probe
will return error as before.

BugLink: thesofproject#1658
BugLink: https://bugzilla.opensuse.org/show_bug.cgi?id=1163677
BugLink: https://bugzilla.kernel.org/show_bug.cgi?id=206085
Signed-off-by: Kai Vehmanen <[email protected]>
kv2019i added a commit to kv2019i/linux that referenced this issue Feb 18, 2020
@kv2019i
ASoC: SOF: Intel: hda: allow operation without i915 gfx
6574cb7 
Add support to configure the HDA controller with an external HDA
codec even if iDisp codec in i915 is not available.

This can happen for multiple reasons:
 - internal graphics is disabled on the system
 - i915 driver is not enabled in kernel or it fails to init
 - i915 codec reports error in HDA codec probe
 - HDA codec driver probe fails

Address all these scenarios, but keep using the existing topology.
In case failures occur, HDMI PCM nodes are created, but they will
report error if application tries to use them. No ALSA mixer controls
are created. If the external HDA codec init fails as well, SOF probe
will return error as before.

BugLink: thesofproject#1658
BugLink: https://bugzilla.opensuse.org/show_bug.cgi?id=1163677
BugLink: https://bugzilla.kernel.org/show_bug.cgi?id=206085
Signed-off-by: Kai Vehmanen <[email protected]>
kv2019i added a commit to kv2019i/linux that referenced this issue Feb 18, 2020
@kv2019i
ASoC: intel/skl/hda - add no-HDMI cases to generic HDA driver
3757a94 
Extend the generic HDA driver to support systems where iDisp/HDMI
audio codecs are disabled for some reason. Switch codecs to
SoC dummy in the affected DAI links. This allows to reuse
existing topologies for this case.

BugLink: thesofproject#1658
BugLink: https://bugzilla.opensuse.org/show_bug.cgi?id=1163677
BugLink: https://bugzilla.kernel.org/show_bug.cgi?id=206085
Signed-off-by: Kai Vehmanen <[email protected]>
kv2019i added a commit to kv2019i/linux that referenced this issue Feb 18, 2020
@kv2019i
ASoC: SOF: Intel: hda: allow operation without i915 gfx
ba0aba7 
Add support to configure the HDA controller with an external HDA
codec even if iDisp codec in i915 is not available.

This can happen for multiple reasons:
 - internal graphics is disabled on the system
 - i915 driver is not enabled in kernel or it fails to init
 - i915 codec reports error in HDA codec probe
 - HDA codec driver probe fails

Address all these scenarios, but keep using the existing topology.
In case failures occur, HDMI PCM nodes are created, but they will
report error if application tries to use them. No ALSA mixer controls
are created. If the external HDA codec init fails as well, SOF probe
will return error as before.

BugLink: thesofproject#1658
BugLink: https://bugzilla.opensuse.org/show_bug.cgi?id=1163677
BugLink: https://bugzilla.kernel.org/show_bug.cgi?id=206085
Signed-off-by: Kai Vehmanen <[email protected]>
@kv2019i
Copy link
Collaborator

kv2019i commented Feb 20, 2020

Patch submitted to alsa-devel for this bug.

ruscur pushed a commit to ruscur/linux3 that referenced this issue Feb 21, 2020
@kv2019i @broonie
ASoC: intel/skl/hda - add no-HDMI cases to generic HDA driver
d2ad9d6 
Extend the generic HDA driver to support systems where iDisp/HDMI
audio codecs are disabled for some reason. Switch codecs to
SoC dummy in the affected DAI links. This allows to reuse
existing topologies for this case.

Signed-off-by: Kai Vehmanen <[email protected]>
Reviewed-by: Pierre-Louis Bossart <[email protected]>
Reviewed-by: Ranjani Sridharan <[email protected]>
BugLink: https://bugzilla.kernel.org/show_bug.cgi?id=206085
BugLink: https://bugzilla.opensuse.org/show_bug.cgi?id=1163677
BugLink: thesofproject/linux#1658
Link: https://lore.kernel.org/r/[email protected]
Signed-off-by: Mark Brown <[email protected]>
ruscur pushed a commit to ruscur/linux3 that referenced this issue Feb 21, 2020
@kv2019i @broonie
ASoC: SOF: Intel: hda: allow operation without i915 gfx
71cc8ab 
Add support to configure the HDA controller with an external HDA
codec even if iDisp codec in i915 is not available.

This can happen for multiple reasons:
 - internal graphics is disabled on the system
 - i915 driver is not enabled in kernel or it fails to init
 - i915 codec reports error in HDA codec probe
 - HDA codec driver probe fails

Address all these scenarios, but keep using the existing topology.
In case failures occur, HDMI PCM nodes are created, but they will
report error if application tries to use them. No ALSA mixer controls
are created. If the external HDA codec init fails as well, SOF probe
will return error as before.

Signed-off-by: Kai Vehmanen <[email protected]>
Reviewed-by: Pierre-Louis Bossart <[email protected]>
Reviewed-by: Ranjani Sridharan <[email protected]>
BugLink: https://bugzilla.kernel.org/show_bug.cgi?id=206085
BugLink: https://bugzilla.opensuse.org/show_bug.cgi?id=1163677
BugLink: thesofproject/linux#1658
Link: https://lore.kernel.org/r/[email protected]
Signed-off-by: Mark Brown <[email protected]>
@kv2019i
Copy link
Collaborator

kv2019i commented Mar 31, 2020

Patch merged upstream and merged back to sof-dev as well. Closing.

@kv2019i kv2019i closed this as completed Mar 31, 2020
jason77-wang pushed a commit to jason77-wang/linux-1 that referenced this issue Apr 10, 2020
@kv2019i @jason77-wang
ASoC: SOF: Intel: hda: allow operation without i915 gfx
dce7ce1 
Add support to configure the HDA controller with an external HDA
codec even if iDisp codec in i915 is not available.

This can happen for multiple reasons:
 - internal graphics is disabled on the system
 - i915 driver is not enabled in kernel or it fails to init
 - i915 codec reports error in HDA codec probe
 - HDA codec driver probe fails

Address all these scenarios, but keep using the existing topology.
In case failures occur, HDMI PCM nodes are created, but they will
report error if application tries to use them. No ALSA mixer controls
are created. If the external HDA codec init fails as well, SOF probe
will return error as before.

Signed-off-by: Kai Vehmanen <[email protected]>
Reviewed-by: Pierre-Louis Bossart <[email protected]>
Reviewed-by: Ranjani Sridharan <[email protected]>
BugLink: https://bugzilla.kernel.org/show_bug.cgi?id=206085
BugLink: https://bugzilla.opensuse.org/show_bug.cgi?id=1163677
BugLink: thesofproject#1658
Link: https://lore.kernel.org/r/[email protected]
Signed-off-by: Mark Brown <[email protected]>
(cherry picked from commit 71cc8ab)
Signed-off-by: Hui Wang <[email protected]>
jason77-wang pushed a commit to jason77-wang/linux-1 that referenced this issue Apr 10, 2020
@kv2019i @jason77-wang
ASoC: intel/skl/hda - add no-HDMI cases to generic HDA driver
ad06a3b 
Extend the generic HDA driver to support systems where iDisp/HDMI
audio codecs are disabled for some reason. Switch codecs to
SoC dummy in the affected DAI links. This allows to reuse
existing topologies for this case.

Signed-off-by: Kai Vehmanen <[email protected]>
Reviewed-by: Pierre-Louis Bossart <[email protected]>
Reviewed-by: Ranjani Sridharan <[email protected]>
BugLink: https://bugzilla.kernel.org/show_bug.cgi?id=206085
BugLink: https://bugzilla.opensuse.org/show_bug.cgi?id=1163677
BugLink: thesofproject#1658
Link: https://lore.kernel.org/r/[email protected]
Signed-off-by: Mark Brown <[email protected]>
(cherry picked from commit d2ad9d6)
Signed-off-by: Hui Wang <[email protected]>
jason77-wang pushed a commit to jason77-wang/linux-1 that referenced this issue Apr 15, 2020
@kv2019i @jason77-wang
ASoC: SOF: Intel: hda: allow operation without i915 gfx
c45ae3c 
BugLink: https://bugs.launchpad.net/bugs/1872916

Add support to configure the HDA controller with an external HDA
codec even if iDisp codec in i915 is not available.

This can happen for multiple reasons:
 - internal graphics is disabled on the system
 - i915 driver is not enabled in kernel or it fails to init
 - i915 codec reports error in HDA codec probe
 - HDA codec driver probe fails

Address all these scenarios, but keep using the existing topology.
In case failures occur, HDMI PCM nodes are created, but they will
report error if application tries to use them. No ALSA mixer controls
are created. If the external HDA codec init fails as well, SOF probe
will return error as before.

Signed-off-by: Kai Vehmanen <[email protected]>
Reviewed-by: Pierre-Louis Bossart <[email protected]>
Reviewed-by: Ranjani Sridharan <[email protected]>
BugLink: https://bugzilla.kernel.org/show_bug.cgi?id=206085
BugLink: https://bugzilla.opensuse.org/show_bug.cgi?id=1163677
BugLink: thesofproject#1658
Link: https://lore.kernel.org/r/[email protected]
Signed-off-by: Mark Brown <[email protected]>
(cherry picked from commit 71cc8ab
git://github.com/thesofproject/linux.git)
Signed-off-by: Hui Wang <[email protected]>
jason77-wang pushed a commit to jason77-wang/linux-1 that referenced this issue Apr 15, 2020
@kv2019i @jason77-wang
ASoC: intel/skl/hda - add no-HDMI cases to generic HDA driver
df6549a 
BugLink: https://bugs.launchpad.net/bugs/1872916

Extend the generic HDA driver to support systems where iDisp/HDMI
audio codecs are disabled for some reason. Switch codecs to
SoC dummy in the affected DAI links. This allows to reuse
existing topologies for this case.

Signed-off-by: Kai Vehmanen <[email protected]>
Reviewed-by: Pierre-Louis Bossart <[email protected]>
Reviewed-by: Ranjani Sridharan <[email protected]>
BugLink: https://bugzilla.kernel.org/show_bug.cgi?id=206085
BugLink: https://bugzilla.opensuse.org/show_bug.cgi?id=1163677
BugLink: thesofproject#1658
Link: https://lore.kernel.org/r/[email protected]
Signed-off-by: Mark Brown <[email protected]>
(cherry picked from commit d2ad9d6
git://github.com/thesofproject/linux.git)
Signed-off-by: Hui Wang <[email protected]>
cujomalainey pushed a commit to cujomalainey/linux that referenced this issue Apr 16, 2020
@kv2019i @cujomalainey
UPSTREAM: ASoC: intel/skl/hda - add no-HDMI cases to generic HDA driver
c3a8426 
Extend the generic HDA driver to support systems where iDisp/HDMI
audio codecs are disabled for some reason. Switch codecs to
SoC dummy in the affected DAI links. This allows to reuse
existing topologies for this case.

Signed-off-by: Kai Vehmanen <[email protected]>
Reviewed-by: Pierre-Louis Bossart <[email protected]>
Reviewed-by: Ranjani Sridharan <[email protected]>
BugLink: https://bugzilla.kernel.org/show_bug.cgi?id=206085
BugLink: https://bugzilla.opensuse.org/show_bug.cgi?id=1163677
BugLink: thesofproject#1658
Link: https://lore.kernel.org/r/[email protected]
Signed-off-by: Mark Brown <[email protected]>
(cherry picked from commit d2ad9d6)
Signed-off-by: Chintan Patel <[email protected]>

BUG=b:153422295
TEST=No audio regression on TGL/JSL devices

Change-Id: I2ba96f9af98d1f4e2f4ada283eb34b1f2ac7100a
cujomalainey pushed a commit to cujomalainey/linux that referenced this issue Apr 16, 2020
@kv2019i @cujomalainey
UPSTREAM: ASoC: SOF: Intel: hda: allow operation without i915 gfx
91dc92b 
Add support to configure the HDA controller with an external HDA
codec even if iDisp codec in i915 is not available.

This can happen for multiple reasons:
 - internal graphics is disabled on the system
 - i915 driver is not enabled in kernel or it fails to init
 - i915 codec reports error in HDA codec probe
 - HDA codec driver probe fails

Address all these scenarios, but keep using the existing topology.
In case failures occur, HDMI PCM nodes are created, but they will
report error if application tries to use them. No ALSA mixer controls
are created. If the external HDA codec init fails as well, SOF probe
will return error as before.

Signed-off-by: Kai Vehmanen <[email protected]>
Reviewed-by: Pierre-Louis Bossart <[email protected]>
Reviewed-by: Ranjani Sridharan <[email protected]>
BugLink: https://bugzilla.kernel.org/show_bug.cgi?id=206085
BugLink: https://bugzilla.opensuse.org/show_bug.cgi?id=1163677
BugLink: thesofproject#1658
Link: https://lore.kernel.org/r/[email protected]
Signed-off-by: Mark Brown <[email protected]>
(cherry picked from commit 71cc8ab)
Signed-off-by: Chintan Patel <[email protected]>

BUG=b:153422295
TEST=No audio regression on TGL/JSL devices

Change-Id: I99066b97aa309624cc3c220e09fa08dca094ef4f
cujomalainey pushed a commit to cujomalainey/linux that referenced this issue Apr 16, 2020
@kv2019i @cujomalainey
UPSTREAM: ASoC: intel/skl/hda - add no-HDMI cases to generic HDA driver
382073f 
Extend the generic HDA driver to support systems where iDisp/HDMI
audio codecs are disabled for some reason. Switch codecs to
SoC dummy in the affected DAI links. This allows to reuse
existing topologies for this case.

Signed-off-by: Kai Vehmanen <[email protected]>
Reviewed-by: Pierre-Louis Bossart <[email protected]>
Reviewed-by: Ranjani Sridharan <[email protected]>
BugLink: https://bugzilla.kernel.org/show_bug.cgi?id=206085
BugLink: https://bugzilla.opensuse.org/show_bug.cgi?id=1163677
BugLink: thesofproject#1658
Link: https://lore.kernel.org/r/[email protected]
Signed-off-by: Mark Brown <[email protected]>
(cherry picked from commit d2ad9d6)
Signed-off-by: Chintan Patel <[email protected]>

BUG=b:153422295
TEST=No audio regression on TGL/JSL devices

Change-Id: I2ba96f9af98d1f4e2f4ada283eb34b1f2ac7100a
Signed-off-by: Curtis Malainey <[email protected]>
cujomalainey pushed a commit to cujomalainey/linux that referenced this issue Apr 16, 2020
@kv2019i @cujomalainey
UPSTREAM: ASoC: SOF: Intel: hda: allow operation without i915 gfx
2abbc3d 
Add support to configure the HDA controller with an external HDA
codec even if iDisp codec in i915 is not available.

This can happen for multiple reasons:
 - internal graphics is disabled on the system
 - i915 driver is not enabled in kernel or it fails to init
 - i915 codec reports error in HDA codec probe
 - HDA codec driver probe fails

Address all these scenarios, but keep using the existing topology.
In case failures occur, HDMI PCM nodes are created, but they will
report error if application tries to use them. No ALSA mixer controls
are created. If the external HDA codec init fails as well, SOF probe
will return error as before.

Signed-off-by: Kai Vehmanen <[email protected]>
Reviewed-by: Pierre-Louis Bossart <[email protected]>
Reviewed-by: Ranjani Sridharan <[email protected]>
BugLink: https://bugzilla.kernel.org/show_bug.cgi?id=206085
BugLink: https://bugzilla.opensuse.org/show_bug.cgi?id=1163677
BugLink: thesofproject#1658
Link: https://lore.kernel.org/r/[email protected]
Signed-off-by: Mark Brown <[email protected]>
(cherry picked from commit 71cc8ab)
Signed-off-by: Chintan Patel <[email protected]>

BUG=b:153422295
TEST=No audio regression on TGL/JSL devices

Change-Id: I99066b97aa309624cc3c220e09fa08dca094ef4f
Signed-off-by: Curtis Malainey <[email protected]>
cujomalainey pushed a commit to cujomalainey/linux that referenced this issue Apr 16, 2020
@kv2019i @cujomalainey
UPSTREAM: ASoC: intel/skl/hda - add no-HDMI cases to generic HDA driver
153f9ca 
Extend the generic HDA driver to support systems where iDisp/HDMI
audio codecs are disabled for some reason. Switch codecs to
SoC dummy in the affected DAI links. This allows to reuse
existing topologies for this case.

Signed-off-by: Kai Vehmanen <[email protected]>
Reviewed-by: Pierre-Louis Bossart <[email protected]>
Reviewed-by: Ranjani Sridharan <[email protected]>
BugLink: https://bugzilla.kernel.org/show_bug.cgi?id=206085
BugLink: https://bugzilla.opensuse.org/show_bug.cgi?id=1163677
BugLink: thesofproject#1658
Link: https://lore.kernel.org/r/[email protected]
Signed-off-by: Mark Brown <[email protected]>
(cherry picked from commit d2ad9d6)
Signed-off-by: Chintan Patel <[email protected]>

BUG=b:153422295
TEST=No audio regression on TGL/JSL devices

Change-Id: I2ba96f9af98d1f4e2f4ada283eb34b1f2ac7100a
Signed-off-by: Curtis Malainey <[email protected]>
cujomalainey pushed a commit to cujomalainey/linux that referenced this issue Apr 16, 2020
@kv2019i @cujomalainey
UPSTREAM: ASoC: SOF: Intel: hda: allow operation without i915 gfx
89a9276 
Add support to configure the HDA controller with an external HDA
codec even if iDisp codec in i915 is not available.

This can happen for multiple reasons:
 - internal graphics is disabled on the system
 - i915 driver is not enabled in kernel or it fails to init
 - i915 codec reports error in HDA codec probe
 - HDA codec driver probe fails

Address all these scenarios, but keep using the existing topology.
In case failures occur, HDMI PCM nodes are created, but they will
report error if application tries to use them. No ALSA mixer controls
are created. If the external HDA codec init fails as well, SOF probe
will return error as before.

Signed-off-by: Kai Vehmanen <[email protected]>
Reviewed-by: Pierre-Louis Bossart <[email protected]>
Reviewed-by: Ranjani Sridharan <[email protected]>
BugLink: https://bugzilla.kernel.org/show_bug.cgi?id=206085
BugLink: https://bugzilla.opensuse.org/show_bug.cgi?id=1163677
BugLink: thesofproject#1658
Link: https://lore.kernel.org/r/[email protected]
Signed-off-by: Mark Brown <[email protected]>
(cherry picked from commit 71cc8ab)
Signed-off-by: Chintan Patel <[email protected]>

BUG=b:153422295
TEST=No audio regression on TGL/JSL devices

Change-Id: I99066b97aa309624cc3c220e09fa08dca094ef4f
Signed-off-by: Curtis Malainey <[email protected]>
cujomalainey pushed a commit to cujomalainey/linux that referenced this issue Apr 23, 2020
@kv2019i @cujomalainey
UPSTREAM: ASoC: intel/skl/hda - add no-HDMI cases to generic HDA driver
2602c7a 
Extend the generic HDA driver to support systems where iDisp/HDMI
audio codecs are disabled for some reason. Switch codecs to
SoC dummy in the affected DAI links. This allows to reuse
existing topologies for this case.

Signed-off-by: Kai Vehmanen <[email protected]>
Reviewed-by: Pierre-Louis Bossart <[email protected]>
Reviewed-by: Ranjani Sridharan <[email protected]>
BugLink: https://bugzilla.kernel.org/show_bug.cgi?id=206085
BugLink: https://bugzilla.opensuse.org/show_bug.cgi?id=1163677
BugLink: thesofproject#1658
Link: https://lore.kernel.org/r/[email protected]
Signed-off-by: Mark Brown <[email protected]>
(cherry picked from commit d2ad9d6)
Signed-off-by: Chintan Patel <[email protected]>

BUG=b:153422295
TEST=No audio regression on TGL/JSL devices

Signed-off-by: Curtis Malainey <[email protected]>
cujomalainey pushed a commit to cujomalainey/linux that referenced this issue Apr 23, 2020
@kv2019i @cujomalainey
UPSTREAM: ASoC: SOF: Intel: hda: allow operation without i915 gfx
53e03c2 
Add support to configure the HDA controller with an external HDA
codec even if iDisp codec in i915 is not available.

This can happen for multiple reasons:
 - internal graphics is disabled on the system
 - i915 driver is not enabled in kernel or it fails to init
 - i915 codec reports error in HDA codec probe
 - HDA codec driver probe fails

Address all these scenarios, but keep using the existing topology.
In case failures occur, HDMI PCM nodes are created, but they will
report error if application tries to use them. No ALSA mixer controls
are created. If the external HDA codec init fails as well, SOF probe
will return error as before.

Signed-off-by: Kai Vehmanen <[email protected]>
Reviewed-by: Pierre-Louis Bossart <[email protected]>
Reviewed-by: Ranjani Sridharan <[email protected]>
BugLink: https://bugzilla.kernel.org/show_bug.cgi?id=206085
BugLink: https://bugzilla.opensuse.org/show_bug.cgi?id=1163677
BugLink: thesofproject#1658
Link: https://lore.kernel.org/r/[email protected]
Signed-off-by: Mark Brown <[email protected]>
(cherry picked from commit 71cc8ab)
Signed-off-by: Chintan Patel <[email protected]>

BUG=b:153422295
TEST=No audio regression on TGL/JSL devices

Signed-off-by: Curtis Malainey <[email protected]>
JeevakaPrabu pushed a commit to projectceladon/linux-intel-lts2019-chromium that referenced this issue Apr 29, 2020
@kv2019i @cujomalainey
UPSTREAM: ASoC: intel/skl/hda - add no-HDMI cases to generic HDA driver
0ed6bdd 
Extend the generic HDA driver to support systems where iDisp/HDMI
audio codecs are disabled for some reason. Switch codecs to
SoC dummy in the affected DAI links. This allows to reuse
existing topologies for this case.

Signed-off-by: Kai Vehmanen <[email protected]>
Reviewed-by: Pierre-Louis Bossart <[email protected]>
Reviewed-by: Ranjani Sridharan <[email protected]>
BugLink: https://bugzilla.kernel.org/show_bug.cgi?id=206085
BugLink: https://bugzilla.opensuse.org/show_bug.cgi?id=1163677
BugLink: thesofproject/linux#1658
Link: https://lore.kernel.org/r/[email protected]
Signed-off-by: Mark Brown <[email protected]>
(cherry picked from commit d2ad9d6ca5b2435754a0fd811f57d30914c612ce)
Signed-off-by: Chintan Patel <[email protected]>

BUG=b:153422295
TEST=No audio regression on TGL/JSL devices

Signed-off-by: Curtis Malainey <[email protected]>
JeevakaPrabu pushed a commit to projectceladon/linux-intel-lts2019-chromium that referenced this issue Apr 29, 2020
@kv2019i @cujomalainey
UPSTREAM: ASoC: SOF: Intel: hda: allow operation without i915 gfx
91726cc 
Add support to configure the HDA controller with an external HDA
codec even if iDisp codec in i915 is not available.

This can happen for multiple reasons:
 - internal graphics is disabled on the system
 - i915 driver is not enabled in kernel or it fails to init
 - i915 codec reports error in HDA codec probe
 - HDA codec driver probe fails

Address all these scenarios, but keep using the existing topology.
In case failures occur, HDMI PCM nodes are created, but they will
report error if application tries to use them. No ALSA mixer controls
are created. If the external HDA codec init fails as well, SOF probe
will return error as before.

Signed-off-by: Kai Vehmanen <[email protected]>
Reviewed-by: Pierre-Louis Bossart <[email protected]>
Reviewed-by: Ranjani Sridharan <[email protected]>
BugLink: https://bugzilla.kernel.org/show_bug.cgi?id=206085
BugLink: https://bugzilla.opensuse.org/show_bug.cgi?id=1163677
BugLink: thesofproject/linux#1658
Link: https://lore.kernel.org/r/[email protected]
Signed-off-by: Mark Brown <[email protected]>
(cherry picked from commit 71cc8abb6ec705ce4efbb54e401004687d40a641)
Signed-off-by: Chintan Patel <[email protected]>

BUG=b:153422295
TEST=No audio regression on TGL/JSL devices

Signed-off-by: Curtis Malainey <[email protected]>
@dzikages555 dzikages555 mentioned this issue Apr 29, 2020
Closed
@dzikages555
Copy link

I have the same or very similar laptop. With ASoC: SOF: Intel: hda: allow operation without i915 gfx patch sof-audio-pci loads, card is detected, but there is no sound and errors appear in dmesg.

See #2065 for more details.

pmatos pushed a commit to pmatos/ubuntu-focal that referenced this issue Jun 26, 2020
@kv2019i @marcelocerri
ASoC: SOF: Intel: hda: allow operation without i915 gfx
ddc1c3e 
BugLink: https://bugs.launchpad.net/bugs/1874698

Add support to configure the HDA controller with an external HDA
codec even if iDisp codec in i915 is not available.

This can happen for multiple reasons:
 - internal graphics is disabled on the system
 - i915 driver is not enabled in kernel or it fails to init
 - i915 codec reports error in HDA codec probe
 - HDA codec driver probe fails

Address all these scenarios, but keep using the existing topology.
In case failures occur, HDMI PCM nodes are created, but they will
report error if application tries to use them. No ALSA mixer controls
are created. If the external HDA codec init fails as well, SOF probe
will return error as before.

Signed-off-by: Kai Vehmanen <[email protected]>
Reviewed-by: Pierre-Louis Bossart <[email protected]>
Reviewed-by: Ranjani Sridharan <[email protected]>
BugLink: https://bugzilla.kernel.org/show_bug.cgi?id=206085
BugLink: https://bugzilla.opensuse.org/show_bug.cgi?id=1163677
BugLink: thesofproject/linux#1658
Link: https://lore.kernel.org/r/[email protected]
Signed-off-by: Mark Brown <[email protected]>
(backported from commit 71cc8abb6ec705ce4efbb54e401004687d40a641)
Signed-off-by: Hui Wang <[email protected]>
Acked-by: Stefan Bader <[email protected]>
Acked-by: Kleber Souza <[email protected]>
Signed-off-by: Khalid Elmously <[email protected]>
pmatos pushed a commit to pmatos/ubuntu-focal that referenced this issue Jun 26, 2020
@kv2019i @marcelocerri
ASoC: intel/skl/hda - add no-HDMI cases to generic HDA driver
c0308a5 
BugLink: https://bugs.launchpad.net/bugs/1874698

Extend the generic HDA driver to support systems where iDisp/HDMI
audio codecs are disabled for some reason. Switch codecs to
SoC dummy in the affected DAI links. This allows to reuse
existing topologies for this case.

Signed-off-by: Kai Vehmanen <[email protected]>
Reviewed-by: Pierre-Louis Bossart <[email protected]>
Reviewed-by: Ranjani Sridharan <[email protected]>
BugLink: https://bugzilla.kernel.org/show_bug.cgi?id=206085
BugLink: https://bugzilla.opensuse.org/show_bug.cgi?id=1163677
BugLink: thesofproject/linux#1658
Link: https://lore.kernel.org/r/[email protected]
Signed-off-by: Mark Brown <[email protected]>
(cherry picked from commit d2ad9d6ca5b2435754a0fd811f57d30914c612ce)
Signed-off-by: Hui Wang <[email protected]>
Acked-by: Stefan Bader <[email protected]>
Acked-by: Kleber Souza <[email protected]>
Signed-off-by: Khalid Elmously <[email protected]>
PlaidCat added a commit to ctrliq/kernel-src-tree that referenced this issue Sep 12, 2024
@PlaidCat
ASoC: intel/skl/hda - add no-HDMI cases to generic HDA driver
b597d87 
jira LE-1907
Rebuild_History Non-Buildable kernel-4.18.0-240.el8
Rebuild_CHGLOG: - [sound] ALSA: ASoC: intel/skl/hda - add no-HDMI cases to generic HDA driver (Jaroslav Kysela) [1797509]
Rebuild_FUZZ: 95.31%
commit-author Kai Vehmanen <[email protected]>
commit d2ad9d6

Extend the generic HDA driver to support systems where iDisp/HDMI
audio codecs are disabled for some reason. Switch codecs to
SoC dummy in the affected DAI links. This allows to reuse
existing topologies for this case.

	Signed-off-by: Kai Vehmanen <[email protected]>
	Reviewed-by: Pierre-Louis Bossart <[email protected]>
	Reviewed-by: Ranjani Sridharan <[email protected]>
BugLink: https://bugzilla.kernel.org/show_bug.cgi?id=206085
BugLink: https://bugzilla.opensuse.org/show_bug.cgi?id=1163677
BugLink: thesofproject/linux#1658
Link: https://lore.kernel.org/r/[email protected]
	Signed-off-by: Mark Brown <[email protected]>
(cherry picked from commit d2ad9d6)
	Signed-off-by: Jonathan Maple <[email protected]>
PlaidCat added a commit to ctrliq/kernel-src-tree that referenced this issue Sep 12, 2024
@PlaidCat
ASoC: SOF: Intel: hda: allow operation without i915 gfx
d88d9f0 
jira LE-1907
Rebuild_History Non-Buildable kernel-4.18.0-240.el8
Rebuild_CHGLOG: - [sound] ALSA: ASoC: SOF: Intel: hda: allow operation without i915 gfx (Jaroslav Kysela) [1797509]
Rebuild_FUZZ: 94.83%
commit-author Kai Vehmanen <[email protected]>
commit 71cc8ab
Empty-Commit: Cherry-Pick Conflicts during history rebuild.
Will be included in final tarball splat. Ref for failed cherry-pick at:
ciq/ciq_backports/kernel-4.18.0-240.el8/71cc8abb.failed

Add support to configure the HDA controller with an external HDA
codec even if iDisp codec in i915 is not available.

This can happen for multiple reasons:
 - internal graphics is disabled on the system
 - i915 driver is not enabled in kernel or it fails to init
 - i915 codec reports error in HDA codec probe
 - HDA codec driver probe fails

Address all these scenarios, but keep using the existing topology.
In case failures occur, HDMI PCM nodes are created, but they will
report error if application tries to use them. No ALSA mixer controls
are created. If the external HDA codec init fails as well, SOF probe
will return error as before.

	Signed-off-by: Kai Vehmanen <[email protected]>
	Reviewed-by: Pierre-Louis Bossart <[email protected]>
	Reviewed-by: Ranjani Sridharan <[email protected]>
BugLink: https://bugzilla.kernel.org/show_bug.cgi?id=206085
BugLink: https://bugzilla.opensuse.org/show_bug.cgi?id=1163677
BugLink: thesofproject/linux#1658
Link: https://lore.kernel.org/r/[email protected]
	Signed-off-by: Mark Brown <[email protected]>
(cherry picked from commit 71cc8ab)
	Signed-off-by: Jonathan Maple <[email protected]>

# Conflicts:
#	sound/soc/sof/intel/hda-codec.c
#	sound/soc/sof/intel/hda.c
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@kv2019i kv2019i

Labels
bug Something isn't working HDA Applies to HD-Audio bus for codec connection P2 Critical bugs or normal features
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

ASoC: SOF: Intel: hda: allow operation without i915 kv2019i/linux
5 participants
@plbossart @singingtelegram @lgirdwood @kv2019i @dzikages555