[BUG] [ICL] SOF codec#0 probe fails on Acer Switch SF314-57G #1807
Comments
|
@perexg thanks for bringing our attention on this The executive summary is: All platforms use the firmware signed with the production Intel key. we cannot query the key used, that's unfortunate but that's the reality. When the firmware is provided through linux-firmware, I'll add a quirk for these exceptions to point to the firmware signed with the community key. I have been able to use the signed firmware on Acer devices since 1.3 In this case, I would think it's a kernel issue (either a missing patch or a bad commit from Intel). can you share the git tree used? |
|
Yep, its 5.4-rc8 with extra backports from 5.5: https://github.com/perexg/linux/tree/perex/fedora-test |
|
Could you try removing all S0ix patches, e.g. starting with c13c962 That series seems to introduce problems and there is on-going work to fix it. Edit: actually trying plain vanilla 5.4-rc8 would be even better, just to make sure there's a reference to bisect from. |
|
Per this kernel log, I don't think that fw is active, it appears like that the upload fails. The PM is not active (I think) in this case. [ 5.793409] sof-audio-pci 0000:00:1f.3: DSP detected with PCI class/subclass/prog-if info 0x040100 [ 5.793702] sof-audio-pci 0000:00:1f.3: Digital mics found on Skylake+ platform, using SOF driver [ 5.793718] sof-audio-pci 0000:00:1f.3: enabling device (0000 -> 0002) [ 5.794122] sof-audio-pci 0000:00:1f.3: warning: No matching ASoC machine driver found [ 5.794148] sof-audio-pci 0000:00:1f.3: DSP detected with PCI class/subclass/prog-if 0x040100 [ 5.794416] sof-audio-pci 0000:00:1f.3: use msi interrupt mode [ 5.794775] sof-audio-pci 0000:00:1f.3: bound 0000:00:02.0 (ops i915_audio_component_bind_ops [i915]) [ 5.799105] sof-audio-pci 0000:00:1f.3: hda codecs found, mask 5 [ 5.799109] sof-audio-pci 0000:00:1f.3: using HDA machine driver skl_hda_dsp_generic now [ 6.804322] sof-audio-pci 0000:00:1f.3: error: codec thesofproject/sof#2 probe error, ret: -5 [ 6.808731] sof-audio-pci 0000:00:1f.3: unexpected ipc interrupt raised! [ 6.808735] sof-audio-pci 0000:00:1f.3: error: no reply expected, received 0x0 [ 9.877648] sof-audio-pci 0000:00:1f.3: error: cl_copy_fw: timeout HDA_DSP_SRAM_REG_ROM_STATUS read [ 9.878144] sof-audio-pci 0000:00:1f.3: error: load fw failed ret: -110 [ 9.878161] sof-audio-pci 0000:00:1f.3: error: status = 0x0000002c panic = 0x00000000 [ 9.878166] sof-audio-pci 0000:00:1f.3: error: failed to reset DSP [ 9.878167] sof-audio-pci 0000:00:1f.3: error: failed to boot DSP firmware -110 [ 9.878167] sof-audio-pci 0000:00:1f.3: error: sof_probe_work failed err: -110 |
|
The first error appears related to the HDaudio codec (or hdmi), can you check what happens if you select the FORCE_NOCODEC mode and use a nocodec topology? That would remove dependencies on the codecs and check if the firmware load works or not. |
|
@perexg another point to verify is the PCI ID of the device. We recently split CFL, CNL and CML firmwares instead of using sof-cnl.ri across the board due to additional firmware manifest/signature differences. If you are using the CNL file on CML, it's likely not going to work. IIRC correctly CFL and CNL are still identical, but CML has a different manifest. @jajanusz please correct me if I am wrong. |
|
The complete alsa-info output is in the Fedora bugzilla (URL provided in the bug description): 00:1f.3 0401: 8086:34c8 (rev 30) Subsystem: 1025:1407 |
|
@perexg @lgirdwood PCI ID 34c8 is IceLake so that's a new one. |
plbossart
changed the title
|
@perexg can you please with the file attached (to be copied as /lib/firmware/intel/sof/sof-icl.ri) |
|
I am just a "proxy" for this from the Fedora's bugzilla. I redirected the user here, so hopefully, he will test this. |
|
new signed binaries now on v1.4.1 release page. |
|
Original reporter here. Unfortunately new firmware makes no difference at all |
|
@omg The updated binaries (CNL and ICL) for SOF 1.4.1 release are available for download. Could you test them and report if issue can be closed ? Thank you. |
|
Unfortunately I've lost ability to boot into Linux after BIOS update. I'll try to do something about it |
|
@omg any updateon your BIOS/Linux installation. Are you able to test ? |
|
There is the same issue in the Ubuntu bug tracker: |
|
Clear Linux: Acer Swift 5: https://community.clearlinux.org/t/new-installation-no-sound-swift-5-i7-1065gt-iris-plus/2407 |
|
The issue title should have Swift instead of Switch I believe. |
|
@perexg @omg @paulmenzel fwiw v1.42 has been released and signed now. |
|
Have still the problem with v1.4.2: [ 11.316829] snd_hda_intel 0000:00:1f.3: DSP detected with PCI class/subclass/prog-if info 0x040100 [ 11.316981] snd_hda_intel 0000:00:1f.3: Digital mics found on Skylake+ platform, using SOF driver [ 11.341573] sof-audio-pci 0000:00:1f.3: DSP detected with PCI class/subclass/prog-if info 0x040100 [ 11.341736] sof-audio-pci 0000:00:1f.3: Digital mics found on Skylake+ platform, using SOF driver [ 11.341762] sof-audio-pci 0000:00:1f.3: enabling device (0000 -> 0002) [ 11.341987] sof-audio-pci 0000:00:1f.3: warning: No matching ASoC machine driver found [ 11.341992] sof-audio-pci 0000:00:1f.3: DSP detected with PCI class/subclass/prog-if 0x040100 [ 11.342191] sof-audio-pci 0000:00:1f.3: use msi interrupt mode [ 11.342359] sof-audio-pci 0000:00:1f.3: bound 0000:00:02.0 (ops i915_audio_component_bind_ops [i915]) [ 11.346610] sof-audio-pci 0000:00:1f.3: hda codecs found, mask 5 [ 11.346611] sof-audio-pci 0000:00:1f.3: using HDA machine driver skl_hda_dsp_generic now [ 11.348580] sof-audio-pci 0000:00:1f.3: error: codec #0 probe error, ret: -2 [ 11.352572] sof-audio-pci 0000:00:1f.3: unexpected ipc interrupt raised! [ 11.352573] sof-audio-pci 0000:00:1f.3: error: no reply expected, received 0x0 [ 11.408362] iwlwifi 0000:00:14.3: base HW address: 0c:dd:24:cc:70:cc [ 11.422048] thermal thermal_zone9: failed to read out thermal zone (-61) [ 11.423850] iwlwifi 0000:00:14.3 wlp0s20f3: renamed from wlan0 [ 11.434988] sof-audio-pci 0000:00:1f.3: Firmware info: version 1:4:2-66a5a [ 11.434990] sof-audio-pci 0000:00:1f.3: Firmware: ABI 3:11:0 Kernel ABI 3:11:0 [ 11.435368] sof-audio-pci 0000:00:1f.3: firmware boot complete` |
|
@ltune thanks, your log is showing that the firmware has booted. Is there any subsequent data in dmesg ? |
|
@ltune wrote:
Hmm, #0 is your external HDA codec (speaker/mics/headset) and -2/NOENT tells that matching codec driver was not found. Can you make sure your kernel is compiled with all the HDA codec drivers included, e.g: CONFIG_SND_HDA_CODEC_REALTEK=m If not still working, can you share the .config file. |
|
The original error code visible in the dmesg is a result of CSME security error. As others have mentioned, a problem with the key signed binary. |
|
@slawblauciak wrote:
I went through the older comments and it seems @ltune confirmed 1.4.2 did boot on the Acer DUT in question (https://github.com/thesofproject/sof/issues/2126#issuecomment-579099179). I checked the linked distro bugs, and I see no conflicting reports on this, so I think we can conclude the remaining issue is not related to firmware loading anymore. So I'll remove the bios tag -- let's keep that for verified cases. Ok for @ltune @perexg @lgirdwood ? |
|
Yes, the 1.4.2 firmware boots fine. |
|
@kv2019i ack, I guess this is kernel related now with HDA integration. @ltune have you had any success with the kernel config suggestion or have you tried a recent kernel (last update was 21 days ago) ? |
|
Hi guys, sorry for late response. @ kv2019i wrote:
I took the ubuntu mainline kernel, in the build log you see that those options are set: LD [M] sound/pci/hda/snd-hda-codec-realtek.o LD [M] sound/pci/hda/snd-hda-codec-cmedia.o LD [M] sound/pci/hda/snd-hda-codec-analog.o LD [M] sound/pci/hda/snd-hda-codec-idt.o LD [M] sound/pci/hda/snd-hda-codec-si3054.o LD [M] sound/pci/hda/snd-hda-codec-cirrus.o LD [M] sound/pci/hda/snd-hda-codec-ca0110.o LD [M] sound/pci/hda/snd-hda-codec-ca0132.o LD [M] sound/pci/hda/snd-hda-codec-conexant.o LD [M] sound/pci/hda/snd-hda-codec-via.o LD [M] sound/pci/hda/snd-hda-codec-hdmi.o LD [M] sound/pci/hda/snd-hda-intel.o @lgirdwood wrote:
I just booted without the snd_hda_intel.dmic_detect=0 and have the same output. I cannot see anything more, but here is the full dmesg @kv2019i wrote:
Right I see also "firmware boot complete" in dmesg, but the result is I have no sound cards available. So for now I continue with the snd_hda_intel.dmic_detect=0 option. |
|
@paulmenzel wrote
right it is acer swift-314-57-77MU |
Add support for using generic codec driver with SOF. Generic driver is used if: - snd_sof_intel_hda_common.hda_model="generic" is set, or - fallback if no other codec driver if found The implementation is aligned with snd-hda-intel driver, and fixes audio support for systems like Acer Swift 3 SF314-57G, on which this issue was originally reported. BugLink: thesofproject#1807 BugLink: https://bugs.launchpad.net/bugs/1877757 Cc: Hui Wang <[email protected]> Signed-off-by: Kai Vehmanen <[email protected]>
Add support for using generic codec driver with SOF. Generic driver is used if: - snd_sof_intel_hda_common.hda_model="generic" is set, or - fallback if no other codec driver is found The implementation is aligned with snd-hda-intel driver, and fixes audio support for systems like Acer Swift 3 SF314-57G, on which this issue was originally reported. BugLink: thesofproject#1807 BugLink: https://bugs.launchpad.net/bugs/1877757 Cc: Hui Wang <[email protected]> Signed-off-by: Kai Vehmanen <[email protected]>
Add support for using generic codec driver with SOF. Generic driver is used if: - snd_sof_intel_hda_common.hda_model="generic" is set, or - fallback if no other codec driver is found The implementation is aligned with snd-hda-intel driver, and fixes audio support for systems like Acer Swift 3 SF314-57G, on which this issue was originally reported. BugLink: #1807 BugLink: https://bugs.launchpad.net/bugs/1877757 Cc: Hui Wang <[email protected]> Signed-off-by: Kai Vehmanen <[email protected]>
Add support for using generic codec driver with SOF. Generic driver is used if: - snd_sof_intel_hda_common.hda_model="generic" is set, or - fallback if no other codec driver is found The implementation is aligned with snd-hda-intel driver, and fixes audio support for systems like Acer Swift 3 SF314-57G, on which this issue was originally reported. BugLink: #1807 BugLink: https://bugs.launchpad.net/bugs/1877757 Cc: Hui Wang <[email protected]> Signed-off-by: Kai Vehmanen <[email protected]> Reviewed-by: Guennadi Liakhovetski <[email protected]> Reviewed-by: Pierre-Louis Bossart <[email protected]>
Add support for using generic codec driver with SOF. Generic driver is used if: - snd_sof_intel_hda_common.hda_model="generic" is set, or - fallback if no other codec driver is found The implementation is aligned with snd-hda-intel driver, and fixes audio support for systems like Acer Swift 3 SF314-57G, on which this issue was originally reported. Signed-off-by: Kai Vehmanen <[email protected]> Reviewed-by: Hui Wang <[email protected]> Reviewed-by: Guennadi Liakhovetski <[email protected]> Reviewed-by: Pierre-Louis Bossart <[email protected]> BugLink: thesofproject#1807 BugLink: https://bugs.launchpad.net/bugs/1877757 Link: https://lore.kernel.org/r/[email protected] Signed-off-by: Mark Brown <[email protected]>
|
I just wanted to say thanks @kv2019i for putting this patch together. I just picked up an Acer Swift 5 (SF514-54T) and was having the same issue as @RiderALT. I found lots of dead-end discussions about this and ultimately only had success when I recompiled the kernel with the two patches above (and added the config options @plbossart linked) -- now it all appears to be working. I've tested both the built-in speakers and mic as well as headset audio and input. I'm on Arch Linux with the 5.6.15-arch1 kernel. In addition to the kernel patches above, I also had to add I still had some issues with PulseAudio. Even pulseaudio 13.99.1 (from git) didn't work out of the box. I ended up going back to the latest pulseaudio packaged by Arch (13.0-3) and added this to Without this, I get only dummy output and no input. I also still get this logging at pulseaudio startup, though all functionality seems to work as expected. If I can assist with any testing or debugging, let me know, I'd be happy to help. Looking forward to seeing this land in 5.8 so I can go back to Arch Linux's packaged kernel. |
Add support for using generic codec driver with SOF. Generic driver is used if: - snd_sof_intel_hda_common.hda_model="generic" is set, or - fallback if no other codec driver is found The implementation is aligned with snd-hda-intel driver, and fixes audio support for systems like Acer Swift 3 SF314-57G, on which this issue was originally reported. BugLink: thesofproject#1807 BugLink: https://bugs.launchpad.net/bugs/1877757 Reviewed-by: Hui Wang <[email protected]> Reviewed-by: Guennadi Liakhovetski <[email protected]> Reviewed-by: Pierre-Louis Bossart <[email protected]> Signed-off-by: Kai Vehmanen <[email protected]>
Add support for using generic codec driver with SOF. Generic driver is used if: - snd_sof_intel_hda_common.hda_model="generic" is set, or - fallback if no other codec driver is found The implementation is aligned with snd-hda-intel driver, and fixes audio support for systems like Acer Swift 3 SF314-57G, on which this issue was originally reported. BugLink: #1807 BugLink: https://bugs.launchpad.net/bugs/1877757 Cc: Hui Wang <[email protected]> Signed-off-by: Kai Vehmanen <[email protected]> Reviewed-by: Guennadi Liakhovetski <[email protected]> Reviewed-by: Pierre-Louis Bossart <[email protected]>
Add support for using generic codec driver with SOF. Generic driver is used if: - snd_sof_intel_hda_common.hda_model="generic" is set, or - fallback if no other codec driver is found The implementation is aligned with snd-hda-intel driver, and fixes audio support for systems like Acer Swift 3 SF314-57G, on which this issue was originally reported. BugLink: #1807 BugLink: https://bugs.launchpad.net/bugs/1877757 Cc: Hui Wang <[email protected]> Signed-off-by: Kai Vehmanen <[email protected]> Reviewed-by: Guennadi Liakhovetski <[email protected]> Reviewed-by: Pierre-Louis Bossart <[email protected]>
|
@samkline : Could you gather the full pulseaudio debug log to check what's wrong? The easiest way is to rename /usr/bin/pulseaudio, kill it and run 'pulseaudio.renamed -vvvvvvvvvvvvvvvv' on the command line (as user). |
|
@samkline could it be that you have an old version of alsa-lib and/or alsa-ucm-conf? we've seen this problem with having to add the number of mics by hand in a pulseaudio configuration, |
|
I believe I'm updated on both: Here's the debug logging of pulseaudio broken (without my changes to /etc/pulse/default.pa): https://gist.github.com/samkline/45d7a05de20ca2c1b34f8ad8440379da And here's the debug logging of pulseaudio working (with my changes to /etc/pulse/default.pa): |
|
The dmic channels are not exported correctly: What does 'amixer -c 0 info' say? |
|
|
Ohh, this was bad hit. The "hw:sofhdadsp,5" device is HDMI3. Please, replace /usr/share/alsa/ucm2/sof-hda-dsp/Hdmi.conf with https://github.com/alsa-project/alsa-ucm-conf/blob/master/ucm2/sof-hda-dsp/Hdmi.conf . |
|
@perexg wrote:
Good catch! Indeed, @samkline you probably have a 514-54T variant with a non-Intel GPU, and you hit this other issue (but fixed in upstream alsa-ucm as Jaroslav points above). |
@kv2019i don't we start the DMIC devices at a fixed offset? |
|
Sadly, no luck -- I tried the Hdmi.conf from upstream, reverted my default.pa change, removed my ~/.config/pulse, and rebooted to be safe, but I get dummy output and no input. Pulseaudio debug logging is available here: https://gist.github.com/samkline/2aff0c71db990e09ad4bdf083666fc9b (lines 115-118 seem potentially relevant) BTW, this machine does have an Intel GPU: |
|
Oh, good news: I just installed pulseaudio-git (13.99.1-31-g1fe37), and it now works with the upstream Hdmi.conf without any changes to default.pa. |
|
Patch to fix the original bug has been merged upstream now, so I will proceed and close the bug: Thank you @ltune , @RiderALT , @perexg and @samkline for reporting and helping with the debug. If there are new issues, please open a new bug and let's track any new issues separately. |
|
That's good news. It may be good to add here which kernel version will contain the patch, once it is released, so I can load the corresponding Ubuntu kernel and have the internal microphone working🙂 |
|
@adam-fu wrote:
It's currently queued for 5.8, so will be in 5.8.0. It may get backported to older stable kernels, and/or Ubuntu kernel package, so you probably don't have to wait that long. |
|
I already apply this patch (commit 89d73cc) for my local build of the kernel 5.7.0 and it works great on my Acer SF314-57 without any additional setting (like kernel module options or pulseaudio settings). The only problem I discovered with 5.7.0 on this machine is 3 HDMI audio outputs in pulseaudio but one HDMI and one thunderbolt output in hardware.i attached Alsa-info output to save a history. |
|
@RiderALT wrote:
That's good to hear, thanks for testing!
This is to be expected. This hardware supports up to 3 concurrent HDMI/DP audio streams. On most systems like this, you can connect upto 3 monitors to the USB-C/thunderbolt port (using DP-MST), plus one to the HDMI connector. Pulseaudio should show which of the three ALSA HDMI PCMs has a connected monitor (in your alsa-info it shows no monitors w/ audio capability connected). |
[ Upstream commit 89d73cc ] Add support for using generic codec driver with SOF. Generic driver is used if: - snd_sof_intel_hda_common.hda_model="generic" is set, or - fallback if no other codec driver is found The implementation is aligned with snd-hda-intel driver, and fixes audio support for systems like Acer Swift 3 SF314-57G, on which this issue was originally reported. Signed-off-by: Kai Vehmanen <[email protected]> Reviewed-by: Hui Wang <[email protected]> Reviewed-by: Guennadi Liakhovetski <[email protected]> Reviewed-by: Pierre-Louis Bossart <[email protected]> BugLink: thesofproject/linux#1807 BugLink: https://bugs.launchpad.net/bugs/1877757 Link: https://lore.kernel.org/r/[email protected] Signed-off-by: Mark Brown <[email protected]> Signed-off-by: Sasha Levin <[email protected]>
BugLink: https://bugs.launchpad.net/bugs/1877757 Add support for using generic codec driver with SOF. Generic driver is used if: - snd_sof_intel_hda_common.hda_model="generic" is set, or - fallback if no other codec driver is found The implementation is aligned with snd-hda-intel driver, and fixes audio support for systems like Acer Swift 3 SF314-57G, on which this issue was originally reported. Signed-off-by: Kai Vehmanen <[email protected]> Reviewed-by: Hui Wang <[email protected]> Reviewed-by: Guennadi Liakhovetski <[email protected]> Reviewed-by: Pierre-Louis Bossart <[email protected]> BugLink: thesofproject/linux#1807 BugLink: https://bugs.launchpad.net/bugs/1877757 Link: https://lore.kernel.org/r/[email protected] Signed-off-by: Mark Brown <[email protected]> (cherry picked from commit 89d73ccab20a684d8446cea4d8ac6a2608c8d390) Signed-off-by: Hui Wang <[email protected]> Acked-by: Stefan Bader <[email protected]> Acked-by: Colin Ian King <[email protected]> Signed-off-by: Kelsey Skunberg <[email protected]>
Add support for using generic codec driver with SOF. Generic driver is used if: - snd_sof_intel_hda_common.hda_model="generic" is set, or - fallback if no other codec driver is found The implementation is aligned with snd-hda-intel driver, and fixes audio support for systems like Acer Swift 3 SF314-57G, on which this issue was originally reported. Signed-off-by: Kai Vehmanen <[email protected]> Reviewed-by: Hui Wang <[email protected]> Reviewed-by: Guennadi Liakhovetski <[email protected]> Reviewed-by: Pierre-Louis Bossart <[email protected]> BugLink: thesofproject/linux#1807 BugLink: https://bugs.launchpad.net/bugs/1877757 Link: https://lore.kernel.org/r/[email protected] Signed-off-by: Mark Brown <[email protected]> (cherry picked from commit 89d73cc) Signed-off-by: Chintan Patel <[email protected]> BUG=b:162008784 TEST=Test audio on volteer. Signed-off-by: Mike Mason <[email protected]>
jira LE-1907 Rebuild_History Non-Buildable kernel-4.18.0-294.el8 Rebuild_CHGLOG: - [sound] ALSA: ASoC: SOF: Intel: hda: fix generic hda codec support (Jaroslav Kysela) [1869536] Rebuild_FUZZ: 94.55% commit-author Kai Vehmanen <[email protected]> commit 89d73cc Add support for using generic codec driver with SOF. Generic driver is used if: - snd_sof_intel_hda_common.hda_model="generic" is set, or - fallback if no other codec driver is found The implementation is aligned with snd-hda-intel driver, and fixes audio support for systems like Acer Swift 3 SF314-57G, on which this issue was originally reported. Signed-off-by: Kai Vehmanen <[email protected]> Reviewed-by: Hui Wang <[email protected]> Reviewed-by: Guennadi Liakhovetski <[email protected]> Reviewed-by: Pierre-Louis Bossart <[email protected]> BugLink: thesofproject/linux#1807 BugLink: https://bugs.launchpad.net/bugs/1877757 Link: https://lore.kernel.org/r/[email protected] Signed-off-by: Mark Brown <[email protected]> (cherry picked from commit 89d73cc) Signed-off-by: Jonathan Maple <[email protected]>
Describe the bug
The user cannot load signed firmware v1.3 on Acer Swift SF314-57G:
https://bugzilla.redhat.com/show_bug.cgi?id=1772498#c16
Discussion:
What is the expected behaviour, if the DSP has own (vendor) authentication key? Basically, how we can determine the right firmware for the given DSP in the generic Linux distribution? We need detect this automatically somehow. Can DSP give any hints to the driver before the fw upload?
The text was updated successfully, but these errors were encountered: