Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FEATURE] configurable FW Loading polling time per platform #1059

Closed
fredoh9 opened this issue Jun 15, 2023 · 1 comment · Fixed by #1067
Closed

[FEATURE] configurable FW Loading polling time per platform #1059

fredoh9 opened this issue Jun 15, 2023 · 1 comment · Fixed by #1067
Assignees
@marc-hb
Labels
P2 Critical bugs or normal features type:enhancement New framework feature or request

Comments

@fredoh9
Copy link
Collaborator

fredoh9 commented Jun 15, 2023 •
edited by marc-hb
Loading

MAX_WAIT_FW_LOADING variable has default value of 70 seconds, The default value was decided high to cover MTL i915 probe timeout. In normal production device, FW loading time is less than a second. It doesn't mean MAX_WAIT_FW_LOADING to waste 70 seconds for every test in every platform, it will escape the polling as soon as FW loading is done.

One concern is raised, even 10 second timeout also pretty luxury but it may hide fw loading delay regression problem. If we can configure

  • MAX_WAIT_FW_LOADING=70s for MTL and newer platforms which might have same i915 driver problem,
  • MAX_WAIT_FW_LOADING=10s for other platforms

And with this configurable feature we can set back 10 seconds for MTL when i915 drivers are upsteamed, in near future.

Related PRs,
@marc-hb
Copy link
Collaborator

marc-hb commented Jun 22, 2023 •
edited
Loading

Here's an interesting datapoint.

thesofproject/sof#7698 broke the MTL build. Tests were started anyway without firmware (tracked in internal issue 139). Each test took 70s to timeout in https://sof-ci.01.org/sofpr/PR7698/build9948/devicetest

The whole PR test plan uselessly hogged 3 MTL devices for more than 200 minutes (internal issues 212 and 139)

@marc-hb marc-hb added type:enhancement New framework feature or request P2 Critical bugs or normal features labels Jun 22, 2023
@marc-hb marc-hb mentioned this issue Jun 22, 2023
Closed
marc-hb added a commit to marc-hb/sof-test that referenced this issue Jun 23, 2023
@marc-hb
lib.sh: make MAX_WAIT_FW_LOADING platform dependent
277e238 
We don't want to wait for 70s in every test on every platform when the
firmware does not load. When multiplied by the number of tests in a plan
this can cause a considerable waste of hardware resources.

i915 timeout aside, 10s has proved over a long period to be more than
enough.

Fixes: thesofproject#1059

Signed-off-by: Marc Herbert <[email protected]>
@marc-hb marc-hb mentioned this issue Jun 24, 2023
Merged
@marc-hb marc-hb self-assigned this Jun 24, 2023
fredoh9 pushed a commit that referenced this issue Jun 26, 2023
@marc-hb @fredoh9
lib.sh: make MAX_WAIT_FW_LOADING platform dependent
5c279c4 
We don't want to wait for 70s in every test on every platform when the
firmware does not load. When multiplied by the number of tests in a plan
this can cause a considerable waste of hardware resources.

i915 timeout aside, 10s has proved over a long period to be more than
enough.

Fixes: #1059

Signed-off-by: Marc Herbert <[email protected]>
@marc-hb marc-hb mentioned this issue Sep 5, 2023
Merged
@marc-hb marc-hb mentioned this issue Oct 11, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@marc-hb marc-hb

Labels
P2 Critical bugs or normal features type:enhancement New framework feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

lib.sh: make MAX_WAIT_FW_LOADING platform dependent marc-hb/sof-test
2 participants
@fredoh9 @marc-hb