check-volume-levels.sh: Shellcheck fixes. #1062
Conversation
|
There has been no testing at all for this PR, @greg-intel can you investigate why? |
I thought that was because it was a draft, but I don't see that being a condition in the PR Builder. Going to run a SOFCI TEST on this... |
CI Testing doesn't test this. Sorry I forgot until a moment ago. |
|
I demoted it to a draft because the lack of testing showed all green and I didn't want it to be merged by accident.
This is very strange, looking like nothing I've seen before. [SKIP CI] is usually in the PR title, not in the PR description. Also, there is still a jenkins line, it's not totally missing. Example: thesofproject/sof#7263 [SKIP CI] 
|
|
wow, another super unusual and strange thing: demoting to draft disables/hides the Github Actions in this PR. This is really not normal! This other draft that I just submitted has all test running as usual: 
|
|
I suspect this PR has been somehow "corrupted" at the Github level. Since we're not going to debug Github, can you please resubmit the same commit in a different and new PR? Don't close or touch this one yet, not before we're sure the other PR works fine. |
greg-intel
force-pushed
the
shellcheck-check-volume-levels
branch
from
a401674 to
bae5afa
Compare
Originally skipped CI, due to the test itself not being part of ci testing.
The test doesn't pass consistently, even run in isolation, as it fails on
volume level checks.
Three instances of...
SC2295 (info): Expansions inside ${..} need to be quoted separately,
otherwise they match as patterns.
Added quotes to $search in this line:
CAP_SWITCH=${tmp#*$search} --> CAP_SWITCH=${tmp#*$search}#*"$search"}
Tested/verified on jf-adlp-rvp-nocodec-8
Signed-off-by: Greg Galloway <[email protected]>
greg-intel
force-pushed
the
shellcheck-check-volume-levels
branch
from
bae5afa to
95bc7c4
Compare
[skip ci] due to this test not being part of ci testing. Test doesn't pass consistently, fails on volume level checks.
Three instances of...
SC2295 (info): Expansions inside ${..} need to be quoted separately, otherwise they match as patterns.
Added quotes to $search in these lines:
CAP_SWITCH=${tmp#*$search}-->CAP_SWITCH=${tmp#*"$search"}Tested/verified on jf-adlp-rvp-nocodec-8