Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

lib.sh: make MAX_WAIT_FW_LOADING platform dependent #1067

Merged
merged 1 commit into from
Jun 26, 2023
Merged

lib.sh: make MAX_WAIT_FW_LOADING platform dependent #1067

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion case-lib/config.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -99,4 +99,6 @@ ENABLE_STORAGE_CHECKS=${ENABLE_STORAGE_CHECKS:-0}
# Set MAX Polling time to check FW Loading. If FW is already loaded, it will
# return immediately. Default value is set to 60 seconds, because i915 driver
# timeout is 60 seconds.
MAX_WAIT_FW_LOADING=${MAX_WAIT_FW_LOADING:-70}

# The default value is defined in case-lib/lib.sh. You can preempt it here:
# MAX_WAIT_FW_LOADING=${MAX_WAIT_FW_LOADING:-90}
9 changes: 9 additions & 0 deletions case-lib/lib.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -77,6 +77,15 @@ start_test()
return 0
}

if test -z "$MAX_WAIT_FW_LOADING"; then
local _pltf; _pltf=$("$SCRIPT_HOME/tools/sof-dump-status.py" -p)
case "$_pltf" in
# broken i915 with long timeout, see comments in config.sh
mtl) MAX_WAIT_FW_LOADING=70;;
*) MAX_WAIT_FW_LOADING=10;; # more than enough
esac
fi

# Check for whether SOF fW is loaded or not before starting any test.
# Only start the polling for firmware boot complete when SOF soundcard is not available
# setup_kernel_check_point has already -1 second to avoid TOCTOU race condition
Expand Down