test-case: add socwatch parsing toool to generate graph #1141
Conversation
It can generate a graph from text output. matplotlib is new dependency. Signed-off-by: Fred Oh <[email protected]>
There was a problem hiding this comment.
Are you sure SoCWatch has no better option? Surely we're not the first ones trying to re-use SoCWatch output. Either some already available python library or at least a more "parser-friendly" output.
EDIT: 1 minor pylint warning:
https://github.com/thesofproject/sof-test/actions/runs/7290667116/job/19867965010?pr=1141
| # Check if the input file parameter is provided | ||
| if len(sys.argv) != 2: | ||
| print("Usage: python script_name.py input_file.txt") | ||
| sys.exit(1) |
There was a problem hiding this comment.
argparse is really easy to use and there are plenty examples.
| lines = file.readlines() | ||
|
|
||
| # Iterate through the lines and extract C-State data | ||
| for line in lines: |
There was a problem hiding this comment.
For now it does not look like you need to read the whole file at once.
| plt.savefig(output_file) | ||
|
|
||
| # Display the plot | ||
| #plt.show() |
There was a problem hiding this comment.
This can be a new argparse option later. No need to add it now but good reason to use argparse now.
There was a problem hiding this comment.
The main feature of this script is not parsing, parsing is only a means to an end. The end is matplotlib, so the script should be named something like sof-socwatch-plot.py
There was a problem hiding this comment.
There is apparently some I've also found mentions of a new "library interface". It wasn't ready at the time but this was last year, so maybe it's usable now. |
|
Demoting to draft as @fredoh9 is on vacation. |
|
SOFCI TEST |
|
@fredoh9 close, re-open if you find time for this? BTW there's a git conflict |
It can generate a graph from text output. matplotlib is new dependency.