Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

lib.sh: Workaround sof-test output alignment issue #1154

Merged
merged 1 commit into from
Jan 19, 2024

Conversation

aiChaoSONG
Copy link

If sof-test test case is run manually and locally, the output of sof-test is messy, the lines are not aligned left at the beginning of each line, some
lines start in the middle of a line, which makes
the output log hard to follow.

This patch helps to workaround the above issue.

Link: #1151

@aiChaoSONG aiChaoSONG requested a review from a team as a code owner January 17, 2024 07:42
Copy link
Collaborator

@marc-hb marc-hb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No objection to the workaround if it works but please add a comment and link to the bug, otherwise there's no reason to do this.

In fact there's a reason NOT to do this (it's not whitespace compatible) but your workaround is more important.

case-lib/lib.sh Outdated Show resolved Hide resolved
If sof-test test case is run manually and locally,
the output of sof-test is messy, the lines are not
aligned left at the beginning of each line, some
lines start in the middle of a line, which makes
the output log hard to follow.

This patch helps to workaround the above issue.

Link: thesofproject#1151

Signed-off-by: Chao Song <[email protected]>
@aiChaoSONG aiChaoSONG merged commit 8341638 into thesofproject:main Jan 19, 2024
4 of 6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants