test-case: add quotes to function arguments for func_export_pipeline #475
Conversation
There was a problem hiding this comment.
Totally agree with the change except it is way too big. For instance is possible some function calls rely sometimes on white space inside the argument, which is bad (it should use a bash array instead) but working and this would break it.
Please resubmit with only the changes you need right now and with a separate commit per function.
aiChaoSONG
force-pushed
the
fix_arg_degrading
branch
from
79583e8 to
dbd67f8
Compare
|
@marc-hb Updated, I only need the change for |
|
Looks good except you kept the older and now misleading commit subject. |
aiChaoSONG
force-pushed
the
fix_arg_degrading
branch
from
dbd67f8 to
ffe5912
Compare
aiChaoSONG
changed the title
aiChaoSONG
force-pushed
the
fix_arg_degrading
branch
from
ffe5912 to
bc2b0f4
Compare
If a shell function takes a variable as its argument, and the variable is empty, then the argument will degrade to nothing in the function. This patch adds quotes to function arguments for func_export_pipeline to avoid argument degrading. Signed-off-by: Amery Song <[email protected]>
|
Travis builds delayed everywhere because of the required migration to travis.com https://travis-ci.community/t/builds-hang-in-queued-state/10250 shellcheck would not have been very helpful in this PR because of the number of files changed. I reviewed every line carefully. The only failure in https://sof-ci.01.org/softestpr/PR475/build346/devicetest/ is a RTC wakeup failure on just one system, this can't be related. Merging this to unblock #430 |
If a shell function takes a variable as its argument,
and the variable is empty, then the argument will
degrade to nothing in the function.
This patch adds quotes to function arguments to avoid
argument degrading.
Signed-off-by: Amery Song [email protected]