[FEATURE] remove duplicated C files additions in CMake rules for src/audio/ modules #8606
Comments
|
Found in Should probably be done before zephyr cleanup: Originally posted by @marc-hb in #8595 (comment)
Looks like @btian1 didn't know (I'm afraid he's submitting uncompiled search/replace) so I had a look at this myself. The answer is: Good thing I just added a Github Action for the ALSA plugin. It may still be incorrect but at least it will still compile? This part of the CMake code is significantly more messy that the rest, it's going to be a huge effort to clean all that technical debt (if ever) |
marc-hb
changed the title
Commit 7680a7b ("cmake: add testbench host build") added a `return()` in the middle of `src/audio/CMakeLists.txt` to exclude some C files from testbench compilation. It wasn't easy to read already at the time. Now that the file has grown bigger it's become even harder to spot and even more confusing. Soon, thesofproject#8260 will also add Zephyr to this file which will make things much worse. Solve all this by moving testbench and plugin compilation to a new, separate, `native.cmake` file. Reported in thesofproject#8606 Signed-off-by: Marc Herbert <[email protected]>
|
Stable-v2.9 branched, this didn't make the cut, bumping to 2.10. |
|
Stable branched for 2.10, so moving this to 2.11. |
|
Feature cutoff for v2.12, moving this to v2.13. |
Is your feature request related to a problem? Please describe.
The list of files to build is duplicated for the shared-library build. Once time in top-level
src/audio/CMakeLists.txtand second time in subfolders.The text was updated successfully, but these errors were encountered: