EQ FIR: Improve robustness with configuration blobs #213
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This patch prevents an error if the EQ responses to channels mapping table in the configuration blob contains less channels than current number of channels in firmware. Without this check the lookup from blob can go past the table. Reporting an error depended on successive blob content to detect corrupt blob and was not guaranteed. The situation is not changed to stop to error but instead extrapolate the table by applying 1st channel EQ for additional channels. It e.g. helps to duplicate mono effect EQ to all channels without need to make blobs with mapping to match max. channels count of SOF. The used response index for each channel can be seen from trace. Signed-off-by: Seppo Ingalsuo <[email protected]>
plbossart
approved these changes
Aug 9, 2018
|
@singalsu can you comment on the array |
|
@lgirdwood That's an array within the configuration blob that preferably should match the channels count if the channels are set to different equalization. E.g. if the the blob defines three EQs #0, #1, #2. This array assign_response[] maps the response to stream channels, e.g. as {2, 1} use EQ shape #2 for channel 0 and EQ shape #1 for channel 1. Was this your question? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch prevents an error if the EQ responses to channels mapping
table in the configuration blob contains less channels than current
number of channels in firmware. Without this check the lookup from blob
can go past the table. Reporting an error depended on successive blob
content to detect corrupt blob and was not guaranteed.
The situation is not changed to stop to error but instead extrapolate
the table by applying 1st channel EQ for additional channels. It e.g.
helps to duplicate mono effect EQ to all channels without need to make
blobs with mapping to match max. channels count of SOF. The used response
index for each channel can be seen from trace.
Signed-off-by: Seppo Ingalsuo [email protected]