ipc4: handler: ipc4_get_large_config_module_instance: Fixed handling of memory allocation error #5699
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
softwarecki
requested review from
lgirdwood,
plbossart,
mmaka1,
lbetlej and
dbaluta
as code owners
|
Can one of the admins verify this patch? |
softwarecki
force-pushed
the
GetLargeConfig-fix
branch
2 times, most recently
from
757e395 to
f125368
Compare
|
@tmleman @RanderWang any comments ? |
lgirdwood
approved these changes
Apr 20, 2022
RanderWang
reviewed
Apr 21, 2022
…of memory allocation error The value returned by the rballoc function is stored in the global variable msg_reply.tx_data. If an allocation error occurs, the function returns an error, but tx_data is overwritten with null. This value is then used in the ipc_msg_send function which leads to null pointer reference. Signed-off-by: Adrian Warecki <[email protected]>
softwarecki
force-pushed
the
GetLargeConfig-fix
branch
from
f125368 to
341fbe4
Compare
tmleman
approved these changes
Apr 22, 2022
RanderWang
approved these changes
Apr 23, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes handling of memory allocation error in ipc4_get_large_config_module_instance function. The value returned by the rballoc function is stored in the global variable msg_reply.tx_data. If an allocation error occurs, the function returns an error, but tx_data is overwritten with null. This value is then used in the ipc_msg_send function which leads to null pointer reference.