Fixes for v2.3-rc1 #6270
Merged
Fixes for v2.3-rc1 #6270
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Cppcheck finds this issue src/math/fft/fft_16.c:23:27: warning: Either the condition '!plan' is redundant or there is possible null pointer dereference: plan. [nullPointerRedundantCheck] struct icomplex16 *inb = plan->inb16; There's same issue with inb and outb in both fft_16.c and fft_32.c Signed-off-by: Seppo Ingalsuo <[email protected]>
Cppcheck found this issue:
src/include/sof/math/fft.h:133:51: error: Shifting by a negative
value is undefined behaviour [shiftNegative]
output->real = sat_int16((((int32_t)input->real >> n_rnd) + 1) >> 1);
^
The case n == 0 need to be handled with the upper if branch non-rounded
shift version.
Signed-off-by: Seppo Ingalsuo <[email protected]>
comp_dbg() statements may be compiled out, so having a 'dev' variable just for debugs is not useful and just ends up with compiler warnings on unused variables. Signed-off-by: Kai Vehmanen <[email protected]>
The parameters px and py in Q_MULTSR_32X32(px, py, qx, qy, qp) function must be cast to (int64_t) if other type. Signed-off-by: Arsen Eloglian <[email protected]>
This patch adds to header file sof/audio/format.h two new macros for 16 * 16 fractional multiply. It's identical to 32 bit but the name suggests that operands are 16 bit where case to int32_t is sufficient for the product. - The calculation of cd->max_frames is changed use Q_MULTSR_16X16() - Max_lag calculation is added type cast to int64_t though it does not overflow with 48 kHz. But it could overflow with 96 kHz rate. - A comment about 64 bit type is added to calculation of thr - src_x and src_y calculation is done with Q_MULTSR_16X16() - az_slow calculation is done with Q_MULTSR_16X16 - deg calculation is done with Q_MULTSR_16X16 Signed-off-by: Seppo Ingalsuo <[email protected]>
Correct the function name "volume_ctrl_set_cmd()" to "volume_set_config()". Signed-off-by: Gongjun Song <[email protected]>
This patch adds cast to int64_t for the multiplication and adds 32 bit saturation to ensure overflow of the product is not possible. This function is used to calculate ramp time in IPC4 NHLT blob mode where the time is not passed from topology. Currently rates up to 48 kHz remain under product int32_t range, so normally there is no issue. However 96 kHz rate would always result to incorrect LOGRAMP_TIME_MIN_MS (10 ms). Signed-off-by: Seppo Ingalsuo <[email protected]>
Found one issue on Linux platform that the initialized volume setting by alsamixer doesn't make effect when playback is started. The reason is that the volume config set is skipped when volume module is just initialized. Now volume will be set when it is initialized. At this time cd->channels is not initialized so use channal count in module config. Signed-off-by: Rander Wang <[email protected]>
Modify the definition of the reset API in the module adapter interface to make sure that it should reset the module state back to MODULE_INITIALIZED and free all memory that was allocated during the prepare() callback. With this change, stopping and restarting streams will always be guaranteed to invoke the module's prepare() callback. Also, fix the passthrough and cadence codec implementation to follow the new definition. Signed-off-by: Guennadi Liakhovetski <[email protected]> Signed-off-by: Ranjani Sridharan <[email protected]>
Size parameter is moved from struct sof_ipc_reply to struct sof_ipc_cmd_hdr. Added changes accordingly. Signed-off-by: Vamshi Krishna Gopal <[email protected]>
lgirdwood
requested review from
a team,
singalsu,
plbossart,
mmaka1,
lbetlej and
dbaluta
as code owners
|
@lgirdwood and @mengdonglin All pause/resume related failures are caused by the PGA volume being too high(maximum). It's not a sof issue and can be fixed by thesofproject/sof-test#953 I will trigger the stress test next. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes for v2.3-rc1
@mengdonglin @keqiaozhang fyi