-
Notifications
You must be signed in to change notification settings - Fork 322
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[CI ONLY] Test #8878
Draft
softwarecki
wants to merge
13
commits into
thesofproject:main
Choose a base branch
from
softwarecki:lib-test
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
[CI ONLY] Test #8878
+143
−180
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
softwarecki
force-pushed
the
lib-test
branch
11 times, most recently
from
February 29, 2024 10:28
d7704c3
to
3bbe5ec
Compare
softwarecki
force-pushed
the
lib-test
branch
4 times, most recently
from
March 4, 2024 12:15
70c22c0
to
1fe992f
Compare
softwarecki
force-pushed
the
lib-test
branch
13 times, most recently
from
March 13, 2024 14:20
d422085
to
d37d689
Compare
softwarecki
force-pushed
the
lib-test
branch
2 times, most recently
from
April 3, 2024 15:10
a25b144
to
f1855e2
Compare
SOFCI TEST |
softwarecki
force-pushed
the
lib-test
branch
2 times, most recently
from
November 27, 2024 15:13
79977c6
to
6e98c8a
Compare
softwarecki
force-pushed
the
lib-test
branch
9 times, most recently
from
January 29, 2025 14:14
16ea3b4
to
1efa535
Compare
Change the type of the UUID parameter in the ipc4_get_drv function to avoid unnecessary typecasting. There are currently two ways to store UUIDs in SOF: as a byte array or as a sof_uuid structure. The ipc4_get_drv function compares UUIDs using the memcmp function, so it is not dependent on the type of the argument passed. This change is intended to prepare the code for standardizing the UUID format across the project. Signed-off-by: Adrian Warecki <[email protected]>
Change the uuid parameter type to void * in the parse_uuid function to make it independent of the UUID type and avoid unnecessary type casting. This change is intended to prepare the code for standardizing the UUID format across the project. Signed-off-by: Adrian Warecki <[email protected]>
Some identifiers are taken from the module manifest. Since the module manifest structure (sof_man_module) is marked as packed, the pointer to the sof_uuid structure may not be properly aligned. Mark the sof_uuid structure as packed to avoid possible problems with accessing fields of this structure from unaligned addresses. Signed-off-by: Adrian Warecki <[email protected]>
Separate the SOF_REG_UUID macro to allow use it to initialize variables with a value from the register. Signed-off-by: Adrian Warecki <[email protected]>
Remove the reference to the first element of the array storing the uuid to prepare the code for changing the uuid type from an array to a struct. Signed-off-by: Adrian Warecki <[email protected]>
Add a & symbol for getting the address of a variable to prepare the code for changing the uuid type from an array to a structure. Signed-off-by: Adrian Warecki <[email protected]>
Change the UUID storage type in the module manifest to a sof-compatible structure to enable retrieval of the UUIDs from the registry. Obtain the UUIDs of loadable llext modules from the uuid-registry. Signed-off-by: Adrian Warecki <[email protected]>
Extend the script that generates the uuid-registry.h file to also generate definitions containing the uuid as a string. These definitions (UUIDREG_STR_...) can be used in toml files, allowing get values from the uuid-registry. Signed-off-by: Adrian Warecki <[email protected]>
Add missing uuids entries for brngup and cold modules in the uuid-registry.txt file. Signed-off-by: Adrian Warecki <[email protected]>
Instruct the toml file preprocessor to also use the definitions from the uuid-registry.h file. This will allow the values placed in the uuid-registry to be used in toml files. Signed-off-by: Adrian Warecki <[email protected]>
Separate the sof_llext_write_uuids function into a new file, llext_write_uuids.cmake. Add support for lowercase uuids. Fix invalid escape before -. Retrieve theidentifiers from a preprocessed rimage_config.toml file, where the uuids names have been replaced with the actual identifiers. To enable this, run the script after building the module. Signed-off-by: Adrian Warecki <[email protected]>
In all preprocessed toml files, replace uuid values with their corresponding identifiers from the uuid-registry. Signed-off-by: Adrian Warecki <[email protected]>
blah blah blah Signed-off-by: Adrian Warecki <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
DNR