[stable-v2.10] backport bugfixes PR9055 and PR9136 #9248
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Free the memory allocated for tplg base and available input/output formats when the topology is freed. Signed-off-by: Ranjani Sridharan <[email protected]> (cherry picked from commit 9b7fffd) Signed-off-by: Kai Vehmanen <[email protected]>
There's a race posiibility in DP when stopping a pipeline: - dp starts processing - incoming IPC - pause the pipeline. IPC has higher priority than DP, so DP is preempted - pipeline is stopping, module "reset" is called. Some of resources may be freed here - when IPC finishes, DP thread continues processing Sollution: wait for DP to finish processing and terminate DP thread before calling "reset" method in module To do this: 1) call "thread cancel" before calling "reset"reset 2) modify "thread cancel" to mark the thread to terminate and execute k_thread_join() 3) terminated thread cannot be restarted, so thread creation must be moved from "init" to "schedule". There's no need to reallocate memory zephyr guarantees that resources may be re-used when a thread is terminated. Signed-off-by: Marcin Szkudlinski <[email protected]> (cherry picked from commit 34957e7) Signed-off-by: Kai Vehmanen <[email protected]>
kv2019i
requested review from
pblaszko,
dbaluta,
LaurentiuM1234,
lgirdwood,
plbossart,
mmaka1 and
lbetlej
as code owners
|
Known pause-resume fail in https://sof-ci.01.org/sofpr/PR9248/build5852/devicetest/index.html , known alsabat fails for LNL in https://sof-ci.01.org/sofpr/PR9248/build5851/devicetest/index.html. Rest looks good, so proceeding with merge. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport following fixes from SOF main:
1e0a9c2 dp: wait till dp thread stops in thread cancel
fe06ef7 tools: plugin: tplg: Fix a couple of memory leaks