switch_tplg: Implement tool for switching topologies #9525
Conversation
Implements a tool for switching between audio topologies without the need for rebooting. Signed-off-by: Anne Onciulescu <[email protected]>
AnneOnciulescu
requested review from
lgirdwood,
plbossart,
mmaka1,
lbetlej,
dbaluta and
kv2019i
as code owners
|
Can one of the admins verify this patch?
|
|
test this please |
|
@AnneOnciulescu can you please add a screenshot and/or a demo. |
| @@ -0,0 +1,12 @@ | |||
| ## Topology Switch Tool | |||
|
|
|||
There was a problem hiding this comment.
Please add a prefix to the commit subject like tools: . Also add some implementations detail in the commit message.
Like for example: we remove and then insert back all SOF related modules thus triggering topology reload.
As a development tool I think this is super useful. On the longer term I wonder if we can have this functionality in the SOF Linux driver.
Cc: @lgirdwood @ranj063
There was a problem hiding this comment.
@dbaluta @AnneOnciulescu would it make sense to update the sof-insert/sof-remove scripts in the sof-test repo to do what you're suggesting? https://github.com/thesofproject/sof-test/tree/main/tools/kmod
And as for choosing a different topology should be just a simple command to se the kernel module params to choose the new topology isnt it? Can you please elaborate the need of the python tool for choosing a different topology?
There was a problem hiding this comment.
Could be yes, but then the user needs to run 3 scripts instead of selecting the topology from a GUI. On the other hand we can create a wrapper over existing sof-insert / sof-remove scripts.
Let me talk to @AnneOnciulescu and get back with a imporved solution.
The GUI offers you a list of topology to use. That is the nicest part. Lets see though if it worth the effort.
There was a problem hiding this comment.
@AnneOnciulescu we also want to namespace all tools with a sof- prefix so that they can be eventually be deployed via a make install or a apt-get install sof-dev
|
@lgirdwood @ranj063 will suspend this PR for a moment so that we can investigate sof_insert.sh and sof_remove.sh |
Implements a tool for switching between audio topologies without the need for rebooting.
After selecting the target topology, certain kernel modules are removed and reloaded, allowing the new topology to take effect.