-
Notifications
You must be signed in to change notification settings - Fork 322
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
config: enable RTC_AEC module for LNL and PTL platforms #9730
base: main
Are you sure you want to change the base?
config: enable RTC_AEC module for LNL and PTL platforms #9730
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@lyakh could we make all the mocks into modules and then load then into CI via UUID ?
@lgirdwood sure, but we'd need topologies that include those stub components to load and test them |
@tmleman please compile AEC as a LLEXT loadable module, we don't need it in production. EDIT: it may also require changes in testing, a module has to be loaded |
@marcinszkudlinski so it is run-time tested in QB? |
test for AEC + Mock is included in internal CI tests |
This patch enables the Google Real Time Communication Audio Processing (RTC_AEC) module for the LNL (Lunar Lake) and PTL (Panther Lake) platforms. The RTC_AEC module is essential for performing echo-cancelling and other real-time audio processing tasks. Changes include: - Enabling CONFIG_COMP_GOOGLE_RTC_AUDIO_PROCESSING and CONFIG_GOOGLE_RTC_AUDIO_PROCESSING_MOCK in the intel_adsp_ace20_lnl.conf configuration file. - Enabling CONFIG_COMP_GOOGLE_RTC_AUDIO_PROCESSING and CONFIG_GOOGLE_RTC_AUDIO_PROCESSING_MOCK in the intel_adsp_ace30_ptl.conf configuration file. This change ensures that the RTC_AEC module is included in the firmware builds for these platforms, allowing for proper testing and functionality of real-time audio processing features. Signed-off-by: Tomasz Leman <[email protected]>
This patch modifies the configuration to change the Google Real Time Communication Audio Processing (RTC_AEC) module from built-in to a loadable module for the MTPM, LNL, and PTL platforms. This change allows for more flexibility in managing the module and reduces the firmware size. Changes include: - Changing CONFIG_COMP_GOOGLE_RTC_AUDIO_PROCESSING from 'y' to 'm' in the intel_adsp_ace15_mtpm.conf configuration file. - Changing CONFIG_COMP_GOOGLE_RTC_AUDIO_PROCESSING from 'y' to 'm' in the intel_adsp_ace20_lnl.conf configuration file. - Changing CONFIG_COMP_GOOGLE_RTC_AUDIO_PROCESSING from 'y' to 'm' in the intel_adsp_ace30_ptl.conf configuration file. - Adding CONFIG_LLEXT, CONFIG_LLEXT_STORAGE_WRITABLE, and CONFIG_MODULES to the intel_adsp_ace30_ptl.conf configuration file to support loadable modules. This change ensures that the RTC_AEC module can be dynamically loaded as needed, providing greater flexibility and potentially improving system performance. Signed-off-by: Tomasz Leman <[email protected]>
9965610
to
4f70175
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'd swap the commits - first convert to "m" where already enabled, and then add directly as "m" where not enabled yet, but the result is the same
@tmleman can you check Internal CI thanks ! |
@lgirdwood PR must wait until the required changes in the tests are implemented. Validation is working on it. |
This patch enables the Google Real Time Communication Audio Processing (RTC_AEC) module for the LNL (Lunar Lake) and PTL (Panther Lake) platforms. The RTC_AEC module is essential for performing echo-cancelling and other real-time audio processing tasks.
Changes include:
This change ensures that the RTC_AEC module is included in the firmware builds for these platforms, allowing for proper testing and functionality of real-time audio processing features.