Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make PulseAudio backend use correct numberOfBuffers #263

Merged
merged 1 commit into from
Mar 18, 2021

Conversation

nyanpasu64
Copy link
Contributor

@nyanpasu64 nyanpasu64 commented Jul 5, 2020

Old behavior is retained if StreamOptions* is null or numberOfBuffers is 0.

I pass in a null pa_buffer_attr* to maintain current behavior. If you instead pass in a non-null pointer where all parameters are -1, then you get around two seconds of latency, which is unacceptable.

Fixes #262.

Old behavior is retained if StreamOptions * is null or
numberOfBuffers is 0.
@garyscavone
Copy link
Contributor

I can't test this ... hopefully it works!

@garyscavone garyscavone merged commit f4b9606 into thestk:master Mar 18, 2021
@nyanpasu64 nyanpasu64 deleted the fix-pulse-latency branch May 25, 2021 08:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

High latency when using PulseAudio, due to missing pa_buffer_attr
2 participants