Swallow i2c read timeouts #24
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit ba34225.
|
I tried to install the PR with "git clone https://github.com/thetic/klipper-sgp40.git -b exceptional" It seems like the error is related to line 14, i'm not quite sure if a relative import over a link (link called sgp40 in ~/klipper/klippy/extras/ which leads to ~/klipper-sgp40/src/klipper_sgp40/) is working I'm not familiar with python, this was just what i was able to find out and may or may not be the case |
|
no dice |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Alternative approach to !21. I did not experience any read timeouts in my testing, but others did. If this works, I'd probably like to combine them, but I want to get some testing of this alone.