Add kubernetes deployment to Express generator #883
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jvasseur
force-pushed
the
kube-express
branch
5 times, most recently
from
4577604 to
5c6c32d
Compare
jvasseur
force-pushed
the
kube-express
branch
from
5c6c32d to
c66007c
Compare
blatinier
approved these changes
Jan 31, 2022
| httpGet: | ||
| path: / | ||
| port: http | ||
| readinessProbe: |
There was a problem hiding this comment.
It would be great later on to have a real url on backends doing a database connection (or a connection to all right adapters) to ensure readyness to receive trafic
There was a problem hiding this comment.
That would indeed be great, I'm adding an issue for latter.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've chosen to not publish sourcemap to Sentry and instead leave them in the docker image since they won't be public, it increase a bit the size of the resulting image (not sure by how much, it could be interesting to measure it) but simplify the build workflow