Use es5-ext/global as a more robust way to resolve browser's window object (global this) #362
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
michaelsbradleyjr
force-pushed
the
polyfill/globalThis
branch
from
07cd70e to
3a3015e
Compare
michaelsbradleyjr
changed the title
|
I updated this PR and its description after realizing the more conservative approach of the |
michaelsbradleyjr
force-pushed
the
polyfill/globalThis
branch
from
3a3015e to
b134a75
Compare
michaelsbradleyjr
changed the title
The [es5-ext/global][es5g] module is based on Mathias Bynens' [polyfill][poly] for [`globalThis`][gT]. It uses the same robust technique but is more conservative in that it does not add a `globalThis` property to the resolved object, i.e. `window` in a browser and `global` in Node. It also lacks the "old IE" fallback seen in a [demo][demo] of the original polyfill, but that is easily provided in this commit. [es5g]: https://github.com/medikoo/es5-ext/blob/master/global.js [poly]: https://mathiasbynens.be/notes/globalthis [gT]: https://github.com/tc39/proposal-global [demo]: https://mathiasbynens.be/demo/globalthis-ie
michaelsbradleyjr
force-pushed
the
polyfill/globalThis
branch
from
b134a75 to
37d3fb7
Compare
13 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to #360.
The es5-ext/global module is based on Mathias Bynens' polyfill for
globalThis. It uses the same robust technique but is more conservative in that it does not add aglobalThisproperty to the resolved object, i.e.windowin a browser andglobalin Node. It also lacks the "old IE" fallback seen in a demo of the original polyfill, but that is easily provided in this commit.