Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve readability of JSON files #12

Closed
lmars opened this issue Dec 30, 2014 · 3 comments · Fixed by #21
Closed

Improve readability of JSON files #12

lmars opened this issue Dec 30, 2014 · 3 comments · Fixed by #21
Labels
enhancement help wanted

Comments

@lmars
Copy link
Contributor

lmars commented Dec 30, 2014

All JSON files should be formatted with MarshalIndent and have a trailing newline at the end.
@lmars lmars mentioned this issue Dec 30, 2014
Merged
titanous added a commit that referenced this issue Jan 2, 2015
@titanous
Indent JSON files
371b13f 
Closes #12

Signed-off-by: Jonathan Rudenberg <[email protected]>
@titanous titanous mentioned this issue Jan 2, 2015
Merged
titanous added a commit that referenced this issue Jan 2, 2015
@titanous
Indent JSON files
5438274 
Closes #12

Signed-off-by: Jonathan Rudenberg <[email protected]>
@titanous titanous self-assigned this Jan 2, 2015
@lmars lmars reopened this Jan 15, 2015
@lmars
Copy link
Contributor Author

lmars commented Jan 15, 2015

The change to indent the JSON (#21) was reverted, see this commit.

@nbering
Copy link

nbering commented Jul 20, 2019

The Update Framework specification requires the use of "canonical JSON", which does not allow for whitespace at all. Perhaps reasonable to close this issue since it violates specification?

https://github.com/theupdateframework/specification/blob/master/tuf-spec.md#4-document-formats
http://wiki.laptop.org/go/Canonical_JSON

@zwass
Copy link
Contributor

zwass commented Apr 27, 2021 •
edited
Loading

Agreed, @lmars @titanous this issue looks like it should be closed given that it would violate the Canonical JSON spec linked by @nbering.

@mnm678 mnm678 closed this as completed Sep 10, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement help wanted
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Indent JSON files theupdateframework/go-tuf
5 participants
@titanous @lmars @zwass @nbering @mnm678