Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Why does "func NewP256Signer()" returns an "ed25519Signer"? #258

Closed
cedricvanrompay-datadog opened this issue Apr 4, 2022 · 1 comment
Closed

Comments

@cedricvanrompay-datadog
Copy link
Contributor

From https://github.com/theupdateframework/go-tuf/blob/0e889ad1c/pkg/keys/ed25519.go#L18:

func NewP256Signer() Signer {
	return &ed25519Signer{}
}

Is this on purpose? Someone calling NewP256Signer would probably expect to get a signer using ECDSA over P-256 curve, and not a signer using Ed25519.

@asraa
Copy link
Contributor

asraa commented Sep 7, 2022

This is fixed now.

You can generate an ecdsa key with keys.GenerateEcdsaKey()

@asraa asraa closed this as completed Sep 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants