feat(keys): JSON unmarshal hardening. #275
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Fixes #258 |
Zenithar
force-pushed
the
feat_key_json_unmarshaller_hardening
branch
from
5c25a92 to
b383cc5
Compare
ethan-lowman-dd
previously approved these changes
Apr 22, 2022
Zenithar
force-pushed
the
feat_key_json_unmarshaller_hardening
branch
3 times, most recently
from
08c4916 to
3085d4b
Compare
|
Branch rebased to |
Zenithar
requested review from
asraa,
joshuagl,
trishankatdatadog and
ethan-lowman-dd
trishankatdatadog
previously approved these changes
Jun 28, 2022
asraa
previously approved these changes
Jun 29, 2022
mnm678
reviewed
Jun 29, 2022
* Add io.LimitReader to block public key content larger than 512Kb. * Fix Ed25519 signer constructor to be referenced as ECDSASigner. * Rename `NewEd25519Signer` to `NewEd25519SignerFromKey` to support the signer registry registration and prevent double declaration. * Add ECDSA unmarshaller tests. Signed-off-by: Thibault Normand <[email protected]>
Signed-off-by: Thibault Normand <[email protected]>
Signed-off-by: Thibault Normand <[email protected]>
Signed-off-by: Thibault Normand <[email protected]>
Signed-off-by: Thibault Normand <[email protected]>
Signed-off-by: Thibault Normand <[email protected]>
Signed-off-by: Thibault Normand <[email protected]>
Signed-off-by: Thibault Normand <[email protected]>
Signed-off-by: Thibault Normand <[email protected]>
Zenithar
force-pushed
the
feat_key_json_unmarshaller_hardening
branch
from
d5af22b to
a2635a0
Compare
|
Branch rebased to master - 0d40b25 |
mnm678
approved these changes
Jul 1, 2022
joshuagl
approved these changes
Jul 19, 2022
|
Great job, thanks Thibault, and Marina/Joshua for reviewing! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Types of changes:
Description of the changes being introduced by the pull request:
NewEd25519SignertoNewEd25519SignerFromKeyto supportthe signer registry registration and prevent double declaration. (breaking-change)
Please verify and check that the pull request fulfills the following requirements: