Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: chmod windows compatible #131

Closed
wants to merge 4 commits into from
Closed

fix: chmod windows compatible #131

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
dd6814f
fix: chmod windows compatible
Mar 15, 2021
f124737
fix: use temp file
Oct 26, 2021
dc7d506
fix: undo change
Oct 26, 2021
7880ae4
fix: retarded devs
Feb 10, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion util/util.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -280,7 +280,7 @@ func AtomicallyWriteFile(filename string, data []byte, perm os.FileMode) error {
return err
}

if err = f.Chmod(perm); err != nil {
if err = os.Chmod(filename, perm); err != nil {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We want to change permissions on the TempFile, f, we have created above rather than the filename passed to the function:

Suggested change
if err = os.Chmod(filename, perm); err != nil {
if err = os.Chmod(f.Name(), perm); err != nil {

f.Close()
os.Remove(f.Name())
return err
Expand Down