refactor: move delegations to pkg/ for export #209
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull Request Test Coverage Report for Build 1747070086
💛 - Coveralls |
ethan-lowman-dd
previously approved these changes
Jan 25, 2022
trishankatdatadog
previously approved these changes
Jan 25, 2022
|
@asraa is it possible to sign your git commits? If not easy to do right now, let me make a workaround. |
Interesting, I wonder why they're not! I use -s on commit, let me see EDIT: Ah, actual signing, not sign-off :D On it, i'll force push with an update |
asraa
dismissed stale reviews from trishankatdatadog and ethan-lowman-dd
via
52b6498
asraa
force-pushed
the
move-delegations
branch
from
c8d855e to
52b6498
Compare
|
All signed :) |
|
Yeah, let me turn off that requirement, thanks! |
trishankatdatadog
approved these changes
Jan 25, 2022
|
friendly ping @ethan-lowman-dd |
ethan-lowman-dd
approved these changes
Jan 26, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Asra Ali [email protected]
Moving the delegation iterator to pkg/ so that the iterator can be accessed in external projects that want to iterate over the delegations and read information like roles/thresholds from delegations.