Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename assertNotNil to assertNoError, since the former name is incorrect #230

Merged
merged 1 commit into from
Mar 4, 2022

Conversation

ethan-lowman-dd
Copy link
Contributor

The assertNotNil helper functions were actually asserting that the error was nil. This PR renames the functions to reflect their actual behavior.

@coveralls
Copy link

coveralls commented Mar 4, 2022

Pull Request Test Coverage Report for Build 1931133902

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 70.23%

Totals Coverage Status
Change from base Build 1924706088: 0.0%
Covered Lines: 2168
Relevant Lines: 3087

💛 - Coveralls

Copy link
Member

@joshuagl joshuagl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks @ethan-lowman-dd.

I assume we're carrying four copies of the same function to avoid the overhead of defining some kind of test utils module (package?)?

@ethan-lowman-dd
Copy link
Contributor Author

@joshuagl I assume so. I'd rather not add another testing module, since the codebase already uses at least two (https://pkg.go.dev/github.com/stretchr/testify and https://pkg.go.dev/gopkg.in/check.v1)

@ethan-lowman-dd ethan-lowman-dd merged commit b98aea5 into master Mar 4, 2022
@ethan-lowman-dd ethan-lowman-dd deleted the ethan.lowman/assertnil branch March 4, 2022 18:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants