[Delegations prereq 9] Make fileSystemStore.GetMeta read metadata files dynamically #231
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull Request Test Coverage Report for Build 1954349102
💛 - Coveralls |
asraa
reviewed
Mar 7, 2022
mnm678
previously approved these changes
Mar 7, 2022
asraa
approved these changes
Mar 7, 2022
ethan-lowman-dd
force-pushed
the
ethan.lowman/delegations-prereq-7
branch
from
160a3ab to
eaefa2e
Compare
ethan-lowman-dd
force-pushed
the
ethan.lowman/delegations-prereq-9
branch
from
e01f344 to
1af01e8
Compare
asraa
previously approved these changes
Mar 8, 2022
…sociated keys. Make NewDelegationsIterator return an error if the passed DB is missing the top level targets role
…sociated keys. Make NewDelegationsIterator return an error if the passed DB is missing the top level targets role
ethan-lowman-dd
force-pushed
the
ethan.lowman/delegations-prereq-9
branch
from
1af01e8 to
e43aa52
Compare
|
Rebasing dismissed reviews. There shouldn't have been any material changes in the rebase. |
mnm678
approved these changes
Mar 9, 2022
asraa
approved these changes
Mar 9, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change helps make #175 smaller. This PR alone shouldn't change any functionality, but it makes
GetMetasupport delegated targets metadata with a one-line change (removing theroles.IsTopLevelManifest(name)check inisMetaFile). This was originally part of #175, but I'm splitting it out for easy review.