-
Notifications
You must be signed in to change notification settings - Fork 110
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: remove GITHUB_TOKEN from arnested/go-version-action #259
chore: remove GITHUB_TOKEN from arnested/go-version-action #259
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@arnested - Thank you for reaching out and for addressing that change in go-tuf too! 👍
edit: Forgot to say that I'd suggest to reword the commit message to comply with the conventional commit guideline, otherwise the linter GitHub action will probably fail 👍
The action `arnested/go-version-action` doesn't need GITHUB_TOKEN anymore. Instead of getting the Go releases from git tags using GitHub's API (and thus needing the token to avoid being rate limited) it pulls the versions from https://go.dev/dl/?mode=json&include=all.
7f6d31a
to
5c72b12
Compare
There were only five projects using GITHUB_TOKEN (not counting my own) so I thought it was a good opportunity to be helpful. Don't expect the same level of service if this ever gains widespread popularity 😛
Fixed 👍 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
This supersedes #260 too
@hosseinsia could you PTAL? should be easy |
6046ed9
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks so much for submitting this @arnested !
Hi,
I'm the author of arnested/go-version-action.
The action doesn't need a GITHUB_TOKEN anymore.
Instead of getting the Go releases from git tags using GitHub's API (and thus needing the token to avoid being rate limited) it pulls the versions from https://go.dev/dl/?mode=json&include=all.