Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: Bump golangci-lint to 1.45.2 #265

Merged
merged 2 commits into from
Apr 12, 2022
Merged

Conversation

ethan-lowman-dd
Copy link
Contributor

@ethan-lowman-dd ethan-lowman-dd commented Apr 8, 2022

Release Notes: Bump golangci-lint to 1.45.2

Types of changes:

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Description of the changes being introduced by the pull request:
Attempts to fix panic in golangci-lint (example: https://github.com/theupdateframework/go-tuf/runs/5889222812?check_suite_focus=true)
Related: golangci/golangci-lint#2374, golangci/golangci-lint#2649

Please verify and check that the pull request fulfills the following requirements:

  • Tests have been added for the bug fix or new feature
  • Docs have been added for the bug fix or new feature

@ethan-lowman-dd ethan-lowman-dd changed the title ci: Bump golangci-lint to 1.45.3 ci: Bump golangci-lint to 1.45.2 Apr 8, 2022
@ethan-lowman-dd ethan-lowman-dd enabled auto-merge (squash) April 8, 2022 20:52
Copy link
Contributor

@rdimitrov rdimitrov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I expected that dependabot would have handled this too, but it seems this is not the case.

Copy link
Contributor

@asraa asraa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah dependabot might not parse action args :/ the only way to track would be to use latest, but that would go against pinning deps

@asraa
Copy link
Contributor

asraa commented Apr 11, 2022

Would be nice to have @rdimitrov's approvals count for review requirements... :)

@joshuagl
Copy link
Member

Would be nice to have @rdimitrov's approvals count for review requirements... :)

I'd second this motion. Should we vote on making him a maintainer?

@trishankatdatadog
Copy link
Member

I'd second this motion. Should we vote on making him a maintainer?

Eff yes

@asraa
Copy link
Contributor

asraa commented Apr 12, 2022

Let's also get one more approval here :)

@ethan-lowman-dd ethan-lowman-dd merged commit a747dcc into master Apr 12, 2022
@ethan-lowman-dd ethan-lowman-dd deleted the ethan.lowman/bump-golang-ci branch April 12, 2022 14:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants