Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

meta: propose rdimitrov as maintainer #268

Merged
merged 1 commit into from
Apr 19, 2022

Conversation

asraa
Copy link
Contributor

@asraa asraa commented Apr 12, 2022

Signed-off-by: Asra Ali [email protected]

Please fill in the fields below to submit a pull request. The more information that is provided, the better.

Fixes #
Release Notes:

Types of changes:

  • [ ] Bug fix (non-breaking change which fixes an issue)
  • [ x ] New feature (non-breaking change which adds functionality)
  • [ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)

Description of the changes being introduced by the pull request:

see title, to improve go-tuf process

Please verify and check that the pull request fulfills the following requirements:

  • [x ] Tests have been added for the bug fix or new feature
  • [ x] Docs have been added for the bug fix or new feature

@asraa asraa requested a review from rdimitrov April 12, 2022 13:27
rdimitrov
rdimitrov previously approved these changes Apr 12, 2022
Copy link
Contributor

@rdimitrov rdimitrov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you so much! ❤️

@asraa
Copy link
Contributor Author

asraa commented Apr 13, 2022

sorry, i had to force push to update the conventional commit!

@asraa
Copy link
Contributor Author

asraa commented Apr 19, 2022

I have 3 (Trishank, Ethan, and I) approvals for this, let's make sure there's a solid majority

@hosseinsia @mnm678 @joshuagl can 2 of you approve as well?

@trishankatdatadog
Copy link
Member

Thinking of also proposing @znewman01 and @cedricvanrompay-datadog, but that's for another PR

Copy link
Member

@joshuagl joshuagl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💯

@asraa
Copy link
Contributor Author

asraa commented Apr 19, 2022

Thanks everyone! Merging with 5/6

@asraa asraa merged commit e2fb0ae into theupdateframework:master Apr 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants