-
Notifications
You must be signed in to change notification settings - Fork 110
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: Update CONTRIBUTING.md, add MAINTAINERS.md #309
Conversation
Signed-off-by: Asra Ali <[email protected]>
Follow-up from theupdateframework#190 (thanks @asraa!). I did not add a DCO requirement at this point, as that was controversial in theupdateframework#190. I filed theupdateframework#308 to track that. I tried to address all *other* feedback in theupdateframework#190. Fixes theupdateframework#212. Fixes theupdateframework#306.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you so so much!
- TODO for testing instructions - Remove obsolete TODO
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm! thank you!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for keeping this moving. I've made a few minor suggestions, but this LGTM as is.
Follow-up from #190 (thanks @asraa!).
I did not add a DCO requirement at this point, as that was controversial in #190. I filed #308 to track that.
I tried to address all other feedback in #190.
Fixes #212.
Fixes #303.
Release Notes: N/A
Types of changes:
Description of the changes being introduced by the pull request:
Doc changes.
Please verify and check that the pull request fulfills the following requirements: