Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add a refresh command #338

Closed
wants to merge 1 commit into from

Conversation

doanac
Copy link
Contributor

@doanac doanac commented Jul 11, 2022

This command is helpful for users that would like to have automation
tooling keep the timestamp and snapshot metadata fresh.

Signed-off-by: Andy Doan [email protected]

Please fill in the fields below to submit a pull request. The more information that is provided, the better.

Types of changes:

  • [ ] Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • [ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)

Description of the changes being introduced by the pull request:

Please verify and check that the pull request fulfills the following requirements:

  • Tests have been added for the bug fix or new feature
  • Docs have been added for the bug fix or new feature

This command is helpful for users that would like to have automation
tooling keep the timestamp and snapshot metadata fresh.

Signed-off-by: Andy Doan <[email protected]>
@asraa
Copy link
Contributor

asraa commented Jul 11, 2022

Linked issue #329

Copy link
Contributor

@asraa asraa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! some basic comments. I'm still a little hesitant that this is necessary to add to the CLI, but I'll let other maintainers chime in (see my discussion on the issue), and won't block on that.

form of TUF_{{ROLE}}_PASSPHRASE

Options:
--snapshot-threshold=<hours> Set the threshold for when to resign expiring
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the wording for threshold is overloaded with the threshold for signing, maybe this could be --snapshot-time or --snapshot-hours? I'm not sure.

Please clarify in this option that this is in hour units

Alternatively, passphrases can be set via environment variables in the
form of TUF_{{ROLE}}_PASSPHRASE

Options:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

also clarify that there is a default of 1 hour.

@joshuagl
Copy link
Member

I think this is superseded by #342, right? Shall we close this PR?

@doanac doanac closed this Jul 19, 2022
@doanac doanac deleted the refresh-roles branch July 19, 2022 15:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants