fix: sign-payload shouldn't recanonicalize payload #479
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
znewman01
force-pushed
the
sign-payload
branch
2 times, most recently
from
1c8e198 to
bbc749f
Compare
Fixes theupdateframework#475. - Add new `Repo.SignRaw` which doesn't canonicalize before signing (and just returns Signatures) - Rename `SignPayload` to `CanonicalizeAndSign` (old name is deprecated; it probably doesn't actually get used so we can rip out next major release.) - Add `sign.MakeSignatures` which does not canonicalize; refactor `sign.Sign` to use it. - Modify offline flow to test this property. - Use `SignRaw` in `tuf sign-payload`. Signed-off-by: Zachary Newman <[email protected]>
joshuagl
approved these changes
Apr 18, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Repo.SignRawwhich doesn't canonicalize before signing (and just returns Signatures)SignPayloadtoCanonicalizeAndSign(old name is deprecated; it probably doesn't actually get used so we can rip out next major release.)sign.MakeSignatureswhich does not canonicalize; refactorsign.Signto use it.SignRawintuf sign-payload.Please fill in the fields below to submit a pull request. The more information that is provided, the better.
Fixes #475.
Release Notes:
Repo.SignPayloadis deprecated; please useCanonicalizeAndSigninstead.tuf sign-payloadto not re-canonicalize the input.Types of changes:
!, as infeat!: change foo).Description of the changes being introduced by the pull request:
Please verify and check that the pull request fulfills the following requirements: