Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not run CI for all Go versions and use caching #606

Merged
merged 1 commit into from
Feb 12, 2024

Conversation

rdimitrov
Copy link
Contributor

The following PR:

  • Removes the tests we were running against all available Go versions above the one we are using in the go.mod file. This sounded useful, but it caused more CI failures than it helps.
  • Sets the cache: true for most go actions

@codecov-commenter
Copy link

codecov-commenter commented Feb 7, 2024

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 70.18%. Comparing base (85bd220) to head (decacdd).
Report is 29 commits behind head on master.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #606   +/-   ##
=======================================
  Coverage   70.18%   70.18%           
=======================================
  Files          10       10           
  Lines        2123     2123           
=======================================
  Hits         1490     1490           
  Misses        517      517           
  Partials      116      116           
Flag Coverage Δ
Go-1.21 ?

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@rdimitrov rdimitrov self-assigned this Feb 8, 2024
Copy link
Member

@kommendorkapten kommendorkapten left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, is the windows tests expected to fail?

@rdimitrov
Copy link
Contributor Author

Looks good, is the windows tests expected to fail?

@kommendorkapten - Yes, they were disabled before, but once we enabled them we saw there're a few issues when targets use the prefixed format we use in the tuf-demo repo.

I've opened an issue, but from what I see it's probably caused by the wrong handling of back/forward slashes when we are translating a target name to a local path name when we create or look for the target file locally.

I don't have a windows machine to properly debug and fix this, so I thought it's better to leave the tests enabled and failing until we get some help on this. Also this way we are open in sharing windows support is not working properly yet.

@rdimitrov rdimitrov merged commit a32f1c4 into theupdateframework:master Feb 12, 2024
20 of 23 checks passed
@rdimitrov rdimitrov deleted the update-ci branch February 12, 2024 23:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants